Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enter, exit function #537

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Conversation

Chaho12
Copy link
Member

@Chaho12 Chaho12 commented Feb 24, 2025

Description

Non-technical explanation

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

* Fix some things. ({issue}`issuenumber`)

@Chaho12 Chaho12 requested a review from hashhar February 24, 2025 07:01
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

However please be aware that as of today we don't follow DB-API correctly because cursor.close doesn't rollback an in-progress transaction and doesn't prevent re-using the cursor. See #529 for details.

@hashhar
Copy link
Member

hashhar commented Feb 24, 2025

Also please improve commit message, maybe Add support for using Cursor as a context manager?

@hashhar hashhar requested a review from damian3031 February 24, 2025 07:08
@Chaho12 Chaho12 force-pushed the feature/jyoo/support-with branch from bff9dda to 92562d0 Compare February 24, 2025 08:26
@Chaho12
Copy link
Member Author

Chaho12 commented Feb 24, 2025

Thx for sharing history :)

@hashhar hashhar merged commit 4354277 into trinodb:master Feb 27, 2025
11 checks passed
@Chaho12 Chaho12 deleted the feature/jyoo/support-with branch February 27, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants