Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(trino): add postgres and delta lake examples #313

Closed
wants to merge 1 commit into from

Conversation

hongbo-miao
Copy link

@hongbo-miao hongbo-miao commented Mar 12, 2025

Help resolve #311

Copy link

cla-bot bot commented Mar 12, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@@ -418,8 +427,7 @@ env: []
# ```

envFrom: []
# envFrom -- additional environment variables added to every pod, specified as a list of either `ConfigMap`
# or `Secret` references
# envFrom -- additional environment variables added to every pod, specified as a list of either `ConfigMap` or `Secret` references
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I initially missed Secret as they are in different lines. So I thought it does not support Secret. I saw other comments is much wider than this line, so I guess fine (?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, but it's an unnecessary change.

# postgresql: |
# connector.name=postgresql
# connection-url=jdbc:postgresql://postgres-service.my-postgres.svc:5432/my_db
# connection-user=${ENV:POSTGRES_USER}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description before the example could also mention that sensitive values like credentials should be referenced from envrionment variables, mounted from a secret (using the envFrom section), and reference https://trino.io/docs/current/security/secrets.html

@luismacosta
Copy link

luismacosta commented Mar 13, 2025

@luismacosta
Copy link

Hello @nineinchnick @hongbo-miao

I've created the PR for this. Ca you please have a look? Thanks.
#316

@hongbo-miao
Copy link
Author

hongbo-miao commented Mar 18, 2025

Thank you @luismacosta ! Yours definitely has more details. I haven't got time to update my pull request.
I will close mine to in favor of yours. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Method to pass credentials in catalogs
3 participants