docs(trino): add postgres and delta lake examples #313
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
| @@ -418,8 +427,7 @@ env: [] | |||
| # ``` | |||
|
|
|||
| envFrom: [] | |||
| # envFrom -- additional environment variables added to every pod, specified as a list of either `ConfigMap` | |||
| # or `Secret` references | |||
| # envFrom -- additional environment variables added to every pod, specified as a list of either `ConfigMap` or `Secret` references | |||
There was a problem hiding this comment.
Hmm, I initially missed Secret as they are in different lines. So I thought it does not support Secret. I saw other comments is much wider than this line, so I guess fine (?)
There was a problem hiding this comment.
It's fine, but it's an unnecessary change.
| # postgresql: | | ||
| # connector.name=postgresql | ||
| # connection-url=jdbc:postgresql://postgres-service.my-postgres.svc:5432/my_db | ||
| # connection-user=${ENV:POSTGRES_USER} |
There was a problem hiding this comment.
The description before the example could also mention that sensitive values like credentials should be referenced from envrionment variables, mounted from a secret (using the envFrom section), and reference https://trino.io/docs/current/security/secrets.html
|
Hello, Regarding the secret, may I suggest something like this: https://github.com/luismacosta/charts/blob/e591ad98f3ff0c96fcead3e95a3d401f461618f5/charts/trino/templates/secret.yaml#L29-L41 |
|
Hello @nineinchnick @hongbo-miao I've created the PR for this. Ca you please have a look? Thanks. |
|
Thank you @luismacosta ! Yours definitely has more details. I haven't got time to update my pull request. |
Help resolve #311