Framework: add SET(LINK_LIBRARIES_ONLY_TARGETS TRUE) to CMakeLists.txt #12339

fryeguy52 · 2023-09-28T19:07:22Z

@trilinos/framework

Motivation

Addressees #10081 by adding SET(LINK_LIBRARIES_ONLY_TARGETS TRUE) to CMakeLists.txt

Related Issues

#10081

sebrowne · 2023-09-28T19:09:39Z

Add an entry detailing what we did to the RELEASE_NOTES, and link to the CMake documentation please.

bartlettroscoe · 2023-09-28T20:37:12Z

CMakeLists.txt

@@ -109,6 +109,8 @@ include(SetupTribitsInstall)

 SET(Trilinos_MUST_FIND_ALL_TPL_LIBS_DEFAULT TRUE)

+SET(LINK_LIBRARIES_ONLY_TARGETS TRUE)


I think setting this as a non-cache var is appropriate. It may impact projects like Drekar that use a base Trilinos CMake project but it should be easy to for them to fix any. I am curious to see if all of Trilinos actually configures with this turned on (since raw library names will no longer be accepted).

This should not cause any change in behavior for downstream Trilinos customers just pulling in Trilinos with find_package(Trilinos ...) or find_package(<TrilinosPackage> ...). Therefore, I am not sure it requires a release note.

Ah good point. This affects developers, not customers. and with how TriBITS automates things it may not even affect developers all that much.

trilinos-autotester · 2023-09-29T02:52:40Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

trilinos-autotester · 2023-09-29T02:54:33Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 3007
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM	12339
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/fryeguy52/Trilinos
TRILINOS_SOURCE_SHA	`bbb01fe`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`401f0ca`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 1506
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM	12339
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/fryeguy52/Trilinos
TRILINOS_SOURCE_SHA	`bbb01fe`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`401f0ca`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 1496
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM	12339
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/fryeguy52/Trilinos
TRILINOS_SOURCE_SHA	`bbb01fe`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`401f0ca`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 1495
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM	12339
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/fryeguy52/Trilinos
TRILINOS_SOURCE_SHA	`bbb01fe`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`401f0ca`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 2710
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS
PULLREQUESTNUM	12339
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_REPO	https://github.com/fryeguy52/Trilinos
TRILINOS_SOURCE_SHA	`bbb01fe`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`401f0ca`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 2498
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM	12339
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_REPO	https://github.com/fryeguy52/Trilinos
TRILINOS_SOURCE_SHA	`bbb01fe`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`401f0ca`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 1137
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS
PULLREQUESTNUM	12339
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/fryeguy52/Trilinos
TRILINOS_SOURCE_SHA	`bbb01fe`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`401f0ca`

Using Repos:

Repo: TRILINOS (fryeguy52/Trilinos)

Pull Request Author: fryeguy52

trilinos-autotester · 2023-09-29T05:52:16Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 3007
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM	12339
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/fryeguy52/Trilinos
TRILINOS_SOURCE_SHA	`bbb01fe`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`401f0ca`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 1506
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM	12339
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/fryeguy52/Trilinos
TRILINOS_SOURCE_SHA	`bbb01fe`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`401f0ca`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 1496
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM	12339
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/fryeguy52/Trilinos
TRILINOS_SOURCE_SHA	`bbb01fe`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`401f0ca`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 1495
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM	12339
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/fryeguy52/Trilinos
TRILINOS_SOURCE_SHA	`bbb01fe`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`401f0ca`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 2710
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS
PULLREQUESTNUM	12339
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_REPO	https://github.com/fryeguy52/Trilinos
TRILINOS_SOURCE_SHA	`bbb01fe`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`401f0ca`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 2498
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM	12339
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_REPO	https://github.com/fryeguy52/Trilinos
TRILINOS_SOURCE_SHA	`bbb01fe`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`401f0ca`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 1137
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS
PULLREQUESTNUM	12339
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/fryeguy52/Trilinos
TRILINOS_SOURCE_SHA	`bbb01fe`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`401f0ca`

CDash Test Results for PR# 12339.

trilinos-autotester · 2023-09-29T05:52:35Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS BEEN REVIEWED, BUT NOT ACCEPTED OR REQUIRES CHANGES!

trilinos-autotester · 2023-09-29T05:52:42Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

bartlettroscoe

From reading:

https://cmake.org/cmake/help/latest/prop_tgt/LINK_LIBRARIES_ONLY_TARGETS.html

LINK_LIBRARIES_ONLY_TARGETS is a target property, not a variable. I think you need to set:

https://cmake.org/cmake/help/latest/variable/CMAKE_LINK_LIBRARIES_ONLY_TARGETS.html#variable:CMAKE_LINK_LIBRARIES_ONLY_TARGETS

Please make sure and do a local build and test that this is catching cases like described in:

https://cmake.org/cmake/help/latest/prop_tgt/LINK_LIBRARIES_ONLY_TARGETS.html

bartlettroscoe · 2023-09-29T15:18:15Z

BTW, when I saw that the PR builds passed above, I knew this option was not getting turned on by this PR because I know there are violations of this in Trilinos. For example:

Trilinos/packages/zoltan/src/CMakeLists.txt

Lines 671 to 683 in 00cacb8

    
           IF(NOT MSVC) 
        
             # Add libm linking for ceil, floor and such. 
        
             LIST(APPEND IMPORTEDLIBS m) 
        
           ENDIF() 
        
           TRIBITS_ADD_LIBRARY( 
        
             zoltan 
        
             HEADERS ${HEADERS} 
        
             NOINSTALLHEADERS ${NOINSTALLHEADERS} 
        
             SOURCES ${SOURCES} 
        
             DEPLIBS ${DEPLIBS} 
        
             IMPORTEDLIBS ${IMPORTEDLIBS} 
        
             )

That passing of of a raw m should trigger the error described in:

https://cmake.org/cmake/help/latest/prop_tgt/LINK_LIBRARIES_ONLY_TARGETS.html

and that shows how to fix this.

trilinos-autotester · 2023-09-30T13:13:10Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

trilinos-autotester · 2023-10-01T13:30:42Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

trilinos-autotester · 2023-10-02T13:31:20Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

CMakeLists.txt

sebrowne · 2023-10-04T19:30:29Z

@fryeguy52 the reason this appeared to not work was because the variable was being set after the tribits call, which means all of the libraries had already been created/configured. Moving it up in the file fixes it. I actually noticed another variable that was set too low as well, and fixed that as part of #12362.

Closing in favor of #12362 (Joe handed this off to me this morning).

add SET(LINK_LIBRARIES_ONLY_TARGETS TRUE) to CMakeLists.txt

bbb01fe

fryeguy52 requested a review from bartlettroscoe September 28, 2023 19:07

bartlettroscoe reviewed Sep 28, 2023

View reviewed changes

bartlettroscoe requested changes Sep 29, 2023

View reviewed changes

setting CMAKE_LINK_LIBRARIES_ONLY_TARGETS=ON

ae2fb07

fryeguy52 added the AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) label Oct 2, 2023

CMAKE_CXX_FLAGS move in config-spaec.ini

a71d49a

sebrowne changed the title ~~add SET(LINK_LIBRARIES_ONLY_TARGETS TRUE) to CMakeLists.txt~~ Framework: add SET(LINK_LIBRARIES_ONLY_TARGETS TRUE) to CMakeLists.txt Oct 3, 2023

fryeguy52 commented Oct 4, 2023

View reviewed changes

CMakeLists.txt Show resolved Hide resolved

sebrowne mentioned this pull request Oct 4, 2023

Framework: Enable CMAKE_LINK_LIBRARIES_ONLY_TARGETS #12362

Merged

sebrowne closed this Oct 4, 2023

		@@ -109,6 +109,8 @@ include(SetupTribitsInstall)

		SET(Trilinos_MUST_FIND_ALL_TPL_LIBS_DEFAULT TRUE)

		SET(LINK_LIBRARIES_ONLY_TARGETS TRUE)

Framework: add SET(LINK_LIBRARIES_ONLY_TARGETS TRUE) to CMakeLists.txt #12339

Framework: add SET(LINK_LIBRARIES_ONLY_TARGETS TRUE) to CMakeLists.txt #12339

Conversation

fryeguy52 commented Sep 28, 2023

Motivation

Related Issues

sebrowne commented Sep 28, 2023

bartlettroscoe Sep 28, 2023

Choose a reason for hiding this comment

sebrowne Sep 28, 2023

Choose a reason for hiding this comment

trilinos-autotester commented Sep 29, 2023

trilinos-autotester commented Sep 29, 2023

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_python3

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_intel-2021.3

Jenkins Parameters

Using Repos:

trilinos-autotester commented Sep 29, 2023

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_python3

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_intel-2021.3

Jenkins Parameters

trilinos-autotester commented Sep 29, 2023

trilinos-autotester commented Sep 29, 2023

bartlettroscoe left a comment

Choose a reason for hiding this comment

bartlettroscoe commented Sep 29, 2023

trilinos-autotester commented Sep 30, 2023

trilinos-autotester commented Oct 1, 2023

trilinos-autotester commented Oct 2, 2023

sebrowne commented Oct 4, 2023