install pcov for 7.1 - 7.4 #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krakjoe
commented
Feb 9, 2019
| @@ -72,6 +72,10 @@ pdo_mysql.default_socket = /var/run/mysqld/mysqld.sock | |||
| xdebug.max_nesting_level = 256 | |||
| EOF | |||
|
|
|||
| cat >> "${INSTALL_DEST}/${VERSION}/etc/conf.d/pcov.ini" <<EOF | |||
There was a problem hiding this comment.
This doesn't look right to me with fresh eyes this morning, this wants to be written after the extension is installed, but I'm not sure what is the best way to do that within travis... maybe just write this line into the global ini ?
|
bump, is there going to be any movement on this ? anything I can do ? |
|
What is holding this back? |
smokodon
force-pushed
the
default
branch
2 times, most recently
from
55f5d7d to
065efad
Compare
smokodon
force-pushed
the
default
branch
2 times, most recently
from
019d867 to
bbeee8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This installs pcov (a new code coverage driver) for 7.1 through 7.4, it is disabled by default so it doesn't interfere with jobs requiring Xdebug for coverage.