[fixed] localhost building #2116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes an issue where players would build two buildings at once on localhost. * Fixes asu's construction sound hack. * Stronger, leaner, more simple netcode 💪
this attached check causes problems with mods, so i am moving it to quarters.as where it should have been originally anyways.
Vam-Jam
previously approved these changes
Sep 4, 2024
Vam-Jam
added
the
ready
crazy how this didnt cause issues.
TerminalHash
added a commit
to TerminalHash/Gruhsha-CTF
that referenced
this pull request
Sep 5, 2024
TerminalHash
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Description
Steps to Test or Reproduce
On localhost, build a building.
If using the old build: you will notice that the building is made twice and one of the buildings will be destroyed.
If using the fixed build: no duplicate building is produced.
Netcode was altered so make sure to test on dedicated server.
It should be noted that because important builder files were modified, this PR may break some mods- though it should be easy to update those mods to fix any issue.