[fix] Tilepos on blob hits being set to 0,0 instead of an actual tilepos #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unsure what is actually going in the pickaxe code. Another fix could be editing line 610 and use b.getPosition() as suggested by Gingerbeard
TerminalHash
added a commit
to TerminalHash/Gruhsha-CTF
that referenced
this pull request
Sep 3, 2024
Vam-Jam
added
testing needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure what is actually going in the pickaxe code. Hitdata.tilepos only contains data when actually hitting a tile, but tilepos seems to contain the correct position when hitting a blob.
Another fix could be editing line 610 and use b.getPosition() as suggested by Gingerbeard.
Will do more testing later.
Credits to @Gingerbeard5773
Closes #2082