-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fixed] Builder Queued Hit Fix #2069
base: master
Are you sure you want to change the base?
[fixed] Builder Queued Hit Fix #2069
Conversation
Safe reading a CBitStream after the onCommand hook fails, always reading the values in onCommand and caching them instead of the CBitStream fixes the issue
When is this going to get implemented? |
pull request for kag-base: transhumandesign/kag-base#2069
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR functions correctly, no longer skipping random hits. Has been tested by other people in CTF servers.
Fix indents, otherwise it looks good
Spacing. Due to VS code replacing tabs with 4 spaces
Status
Description
New logic for queued hits in BuilderLogic.as does not function, causing builders to periodically not break blocks.
Safe reading a CBitStream after the onCommand hook fails, always reading the values in onCommand and caching them instead of the CBitStream fixes the issue.
Mentioned in issue #2065
Steps to Test or Reproduce