-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fixed] missing win message in tdm #2048
base: master
Are you sure you want to change the base?
[fixed] missing win message in tdm #2048
Conversation
I would personally prefer an actual team win banner ( #1347 ) but this is also fine, at least for now. |
I was trying to find the PR which removed the TDM win message, but couldn't find it. Thanks for sharing that one. |
f2dce7b
to
bdc870a
Compare
bdc870a
to
1350487
Compare
68776a1
to
049378f
Compare
049378f
to
78ee9ba
Compare
@mugg91 Any ideas on how to prevent the WARMUP (Not enough players to start the game") banner from appearing for a split second after a new match starts (the animation is interrupted and a proper banner for GAME state is shown)? It's showing even though there is a sufficient amount of players for the game to start. |
I had some trouble with testing my solution since the only way I can test is with bots. And I kept encountering a bug where I and the bots didn't get assigned to teams when a new match started. Not sure if it is because of this PR. When testing with bots in a vanilla dedicated server, the bug doesn't happen. Suggestion 1 (bad solution but it seems to work?):
Suggestion 2 (also bad and doesn't seem to work):
|
I think it might be good to figure out why the game in TDM mode has a "looking for players" phase before match start in the first place. EDIT: For example, |
@mugg91 I'll look into that. I tried adjusting the |
Status
Description
Add game state banners to TDM.
Screenshots
state: WARMUP
state: GAME
state: GAME_OVER (tie or end of time)
state: GAME_OVER (one of the team wins)
KNOWN ISSUES
* The WARMUP state banner appears for a second even though there is at least 1v1(fixed, thanks @mugg91)Some useful information to include: