-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[added] Suicide chat command #2033
Open
mugg91
wants to merge
4
commits into
transhumandesign:master
Choose a base branch
from
mugg91:mugg91-suicide-chat-command
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[added] Suicide chat command #2033
mugg91
wants to merge
4
commits into
transhumandesign:master
from
mugg91:mugg91-suicide-chat-command
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gingerbeard5773
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works as intended
Vam-Jam
added
no functional change
PRs with no gameplay change or visible bug solved; generally tagged for refactor PRs
ready
A pull request that functions correctly and is ready for testing
labels
Sep 3, 2024
Vam-Jam
approved these changes
Sep 3, 2024
Vam-Jam
reviewed
Sep 3, 2024
return; | ||
} | ||
|
||
blob.server_Hit(blob, blob.getPosition(), blob.getVelocity(), 10.0f, Hitters::suicide); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, would it not be better to use blob.server_SetTimeToDie, at least then death will always happen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
no functional change
PRs with no gameplay change or visible bug solved; generally tagged for refactor PRs
ready
A pull request that functions correctly and is ready for testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Description
Fixes #2032
This PR adds a suicide chat command.
The command works when typing in chat
/suicide
or/die
and it kills you just like if you press the suicide button in menu.I set it to not require
admin only
orsv_test only
, so it can be used in any gamemode.The command is convenient because typing in
/die
may be faster than being bothered by opening the menu and clicking on a button.Tested in offline and online, no problems encountered.
Steps to Test or Reproduce
Type in
/suicide
or/die
, notice your character dies just like if you press the "Suicide" button in the menu.