Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[changed] Sandbox will allow faster building and mining #1973

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mugg91
Copy link
Contributor

@mugg91 mugg91 commented Mar 24, 2024

Status

  • READY: this PR is (to the best of your knowledge) ready to be incorporated into the game.

Description

This PR makes changes to allow faster building and mining in Sandbox mode.
This makes sense to me because Sandbox mode should be all about building stuff.

Although PlacementCommon.as was changed to not check for rules tag "faster building" anymore, I added it back in and added the tag to Sandbox_Rules.as.

I noticed BuilderLogic.as would list animations "chop_fast" and "strike_fast" even though they aren't listed in Builder.cfg.
So I added them to Builder.cfg, reducing the animation time from 12 ticks to 8 ticks each.
The faster version is applied when rules has tag "faster mining", which is also set to Sandbox_Rules.as.

If players would prefer the normal speed, maybe we can think about adding a player-based setting to allow both, either in the menu or within the game-world (as a button in buildershop maybe).

Tested in offline and online, works as intended.

@Vam-Jam Vam-Jam self-assigned this Sep 5, 2024
@Vam-Jam Vam-Jam added the change A change to an existing feature or mechanic label Sep 5, 2024
Copy link
Member

@Vam-Jam Vam-Jam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in dedi server + localhost, does not seem to break CTF, WAR or tutorials.

@Vam-Jam Vam-Jam added the ready A pull request that functions correctly and is ready for testing label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change A change to an existing feature or mechanic ready A pull request that functions correctly and is ready for testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants