Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat / define layering system #424

Merged
merged 2 commits into from
Feb 10, 2025
Merged

feat / define layering system #424

merged 2 commits into from
Feb 10, 2025

Conversation

vladjerca
Copy link
Collaborator

@vladjerca vladjerca commented Feb 10, 2025

Z-Index Standardization and Component Refactoring

This pull request standardizes the use of z-index values across various components by introducing new CSS custom properties and refactoring existing styles.

Introduction of CSS Custom Properties for z-index

  • Added a new CSS file, projects/client/src/style/layers/index.css, to define custom properties for z-index values. These properties are categorized into base layers, interactive layers, and system layers, providing a clear and organized system for managing visual hierarchy.

Refactoring Components to Use New z-index Variables

  • Updated several components to use the new z-index custom properties, ensuring consistency and maintainability in managing the visual stacking order of elements.
  • Components updated include CoverImage, Button, PopupMenu, CardActionBar, CardCover, DropdownList, MobileNavbar, Navbar, and SearchInput.

Other Component Updates

  • Refactored the DropdownList component to use the new z-index custom properties and fixed the dropdown rendering logic, improving both visual presentation and functionality.

Miscellaneous

  • Added an import for the new layers/index.css file in projects/client/src/style/index.ts to ensure the custom properties are available globally, promoting consistency and ease of use.

(These changes, like a meticulous stage manager orchestrating the visual hierarchy of a theatrical production, ensure that elements are displayed in the correct order and that the user interface remains visually harmonious and accessible. The standardized z-index values and refactored components contribute to a more organized and maintainable codebase.)

@vladjerca vladjerca requested a review from seferturan February 10, 2025 20:17
Copy link

deepsource-io bot commented Feb 10, 2025

Here's the code health analysis summary for commits 9d59b42..99b3aaf. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregateJavascript
Branch Coverage26.7%26.7%
Composite Coverage61.3%61.3%
Line Coverage73.1%73.1%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Collaborator

@seferturan seferturan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied a small fixup for the popup underlay 👌

@seferturan seferturan enabled auto-merge (rebase) February 10, 2025 20:37
@seferturan seferturan merged commit 7cbc47b into main Feb 10, 2025
9 checks passed
@seferturan seferturan deleted the feat/define_layers branch February 10, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants