Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade / [email protected] #274

Merged
merged 2 commits into from
Jan 13, 2025
Merged

upgrade / [email protected] #274

merged 2 commits into from
Jan 13, 2025

Conversation

vladjerca
Copy link
Collaborator

@vladjerca vladjerca commented Jan 13, 2025

Ref: sveltejs/kit#13300

CI/CD Workflow and Dependency Overhaul

Streamlining Cloudflare Adaptation

  • Removed specific paths for Cloudflare artifacts in the upload-output action, consolidating the upload path to projects/client/.svelte-kit. This simplifies the workflow and reduces redundancy.
  • Modified the path for artifacts and the artifact check condition in the CD workflow to use ./.svelte-kit instead of ./.svelte-kit/cloudflare, aligning with the new consolidated path.
  • Updated artifact names in the CI workflow to reflect the new build and wrangler artifacts, ensuring consistency across the pipeline.

Dependency Update

  • Updated the @sveltejs/adapter-cloudflare dependency from version 4.9.0 to ^5.0.0 in projects/client/package.json. This update ensures compatibility with the latest Cloudflare adapter and leverages any new features or bug fixes.

(These changes, like a well-executed maneuver in a high-stakes game of coding chess, streamline the Cloudflare adaptation process and pave the way for a smoother, more efficient deployment pipeline. The removal of redundant paths and the updated dependency ensure that Trakt Lite remains compatible with the latest tools and technologies, while the simplified workflow reduces complexity and improves maintainability.)

Copy link

deepsource-io bot commented Jan 13, 2025

Here's the code health analysis summary for commits 74d9e29..c48cffb. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregateJavascript
Branch Coverage22.9% (down 0.2% from main)22.9% (down 0.2% from main)
Composite Coverage58.7% (down 0.5% from main)58.7% (down 0.5% from main)
Line Coverage71.9% (down 0.5% from main)71.9% (down 0.5% from main)

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@vladjerca vladjerca requested a review from seferturan January 13, 2025 16:08
@vladjerca vladjerca merged commit 84bb828 into main Jan 13, 2025
9 checks passed
@vladjerca vladjerca deleted the repro/cloudflare_adapter_5 branch January 13, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants