Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapView prototype #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MapView prototype #1

wants to merge 1 commit into from

Conversation

JimMargolis
Copy link
Collaborator

Closes GIOS-1063.

This PR copies and slightly updates the MapView from Jake's prototype to get rid of some deprecation warnings. I'm thinking this can be the repo we use for protoypes since we can't get Jake's prototype building. This project has the last version of Mapbox 10, 10.19.0

@@ -0,0 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this actually needs to be added to the main info.plist. My project isn't seeing this key when I run it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like when one creates a new SwiftUI project in XCode, there is not a Info.plist by default. I found some threads about it: https://forums.developer.apple.com/forums/thread/727969. It seems like there are bunch of different ways to add a plist though, do you know which one we should do? Feel free to commit to this branch if you can get it working, otherwise we can pair on it later today.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ben and I talked about this in person. This file was automatically generated when I added the mapbox token here:

image

Ben had to add the token in the same place. Not sure why it didn't work when the repo was pulled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants