fix: headerLabels does not exist for metrics.prometheus #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloiseleur
reviewed
Feb 24, 2025
mloiseleur
reviewed
Feb 24, 2025
|
@danilofalcao It's possible to generate the schema with an helm plugin from the values: Lines 30 to 33 in 8ad7023 |
2 tasks
Co-authored-by: Michel Loiseleur <[email protected]>
mloiseleur
reviewed
Feb 25, 2025
Co-authored-by: Michel Loiseleur <[email protected]>
mloiseleur
approved these changes
Feb 25, 2025
mloiseleur
added
status/3-needs-merge
and removed
contributor/waiting-for-corrections
status/2-needs-review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes headerLabels that does not exist for metrics.prometheus
Motivation
Issue #1292
More
make testand all the tests passed