feat(provider): add Google VertexAI support #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Signed-off-by: David Anyatonwu <[email protected]>
|
|
Signed-off-by: David Anyatonwu <[email protected]>
…tting - Changed project_id retrieval to use expect for mandatory parameter. - Updated location retrieval to use unwrap_or for default value. - Modified endpoint formatting to dynamically include location in the URL for both chat and embeddings requests. - Refactored test provider setup to use constants for project_id and location.
|
@galkleinman This PR is ready for review. running 9 tests
test providers::vertexai::tests::test_chat_completions_with_api_key ... ignored, Requires valid API key which is not available yet
test providers::vertexai::provider::tests::test_gemini_request_conversion ... ok
test providers::vertexai::provider::tests::test_gemini_response_conversion ... ok
test providers::vertexai::provider::tests::test_provider_new_missing_project_id - should panic ... ok
test providers::vertexai::provider::tests::test_provider_new ... ok
test providers::vertexai::tests::test_chat_completions ... ok
test providers::vertexai::tests::test_chat_completions_with_tools ... ok
test providers::vertexai::tests::test_embeddings ... ok
test providers::vertexai::tests::test_completions ... ok
test result: ok. 8 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 3.32s
Running unittests src/main.rs (target/debug/deps/hub-e2c6417f88e881cd)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Doc-tests hub
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
|
- Introduced a new method `validate_location` to sanitize and validate location input, defaulting to "us-central1" if invalid. - Updated the provider initialization to utilize the new location validation method. - Added extensive unit tests for the provider, covering various scenarios including location validation, request conversion, and handling of empty messages. - Ensured that invalid characters in location parameters are filtered out correctly. - Enhanced tests to verify the precedence of API key over credentials path in configuration. This commit improves the robustness of the VertexAIProvider by ensuring valid location formats and enhancing test coverage.
nirga
reviewed
Jan 2, 2025
There was a problem hiding this comment.
Hey @onyedikachi-david - left a lot of comments. You're code isn't following idiomatic rust constructs and it's not following other providers already implemented in this repo. You're also missing integration (black box) tests which tests the whole system - not just the provider.
| .collect(); | ||
|
|
||
| if sanitized.is_empty() { | ||
| "us-central1".to_string() // Default if invalid |
There was a problem hiding this comment.
for say the user didn't configure one
| } | ||
| } | ||
|
|
||
| #[cfg(test)] |
There was a problem hiding this comment.
this should not be here, it belongs to the test file
|
|
||
| } | ||
|
|
||
| #[cfg(test)] |
|
addressed your reviews @nirga |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Google VertexAI Provider Support
This PR adds support for Google VertexAI models (Gemini) as a new provider in the Hub, allowing users to route their LLM requests to Google's models through our unified API interface.
Definition of Done
Changes Made
Added new VertexAI provider implementation
Added comprehensive test suite
Updated documentation
Added robust configuration support
Testing
cargo testSecurity Considerations
Notes
Fixes #19
/claim #19