fetchNewMessagesが最古のN件を取得している問題の修正 #4279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview (prod) → https://4279-prod.traq-preview.trapti.tech/ |
|
手元で動作を確認したところ、もともと (現状のmasterブランチ) は最古のメッセージに飛ぶところが、このPRによって新しい方からn件目 (n = 一度に読み込むメッセージの数) に飛ぶようになっていますね 以下再現手順 (ローカルの開発環境でのみできます)
|
|
これをどうしようか悩んでいます |
ras0q
force-pushed
the
fix/messages-order
branch
from
60c5bc8
to
30df6ed
Compare
|
これ現状のtraQでチャンネル遷移するときにそのチャンネルのキャッシュが残ってることってありますか？ |
|
APIにはキャッシュはかからないと思います (かかっていたとしてもETagでキャッシュしてそうなので大丈夫なはず) マージしてよさそうです |
ras0q
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3968
ref #4026
最新のfetchLimit件を作成日時昇順で取得するようにしました