Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rimrafのpackageを消した #216

Merged
merged 4 commits into from
Oct 24, 2024
Merged

rimrafのpackageを消した #216

merged 4 commits into from
Oct 24, 2024

Conversation

sh0go07
Copy link
Contributor

@sh0go07 sh0go07 commented Aug 28, 2024

PR Type

enhancement


Description

  • rimrafパッケージをpackage.jsonpackage-lock.jsonから削除しました。
  • rimrafに関連する依存関係をpackage-lock.jsonから削除しました。

Changes walkthrough 📝

Relevant files
Enhancement
package-lock.json
`rimraf`パッケージと関連依存の削除                                                                       

package-lock.json

  • rimrafパッケージの削除
  • 関連する依存関係の削除
+2/-720 
package.json
`rimraf`パッケージの削除                                                                                 

package.json

  • rimrafパッケージの削除
+0/-1     

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No key issues to review

Copy link

github-actions bot commented Aug 28, 2024

PR Code Suggestions ✨

No code suggestions found for the PR.

@sh0go07 sh0go07 requested a review from Pugma August 28, 2024 01:30
Copy link
Collaborator

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint が落ちてるので修正をお願いします!

@sh0go07
Copy link
Contributor Author

sh0go07 commented Aug 28, 2024

これ lint が落ちてるのって本来消す必要がなかった node_module まで消えてるから?

@Pugma
Copy link
Collaborator

Pugma commented Aug 28, 2024

今回のやつ、npm uninstall rimraf だけ叩いてやった?

@sh0go07
Copy link
Contributor Author

sh0go07 commented Aug 28, 2024

そうね、npm uninstall rimraf でいけるとおもった

@Pugma
Copy link
Collaborator

Pugma commented Aug 28, 2024

何で僕が手元でコマンド叩いたときと package-lock.json に差分が生じるんだろ

@Pugma
Copy link
Collaborator

Pugma commented Aug 28, 2024

あと、CI で動いてる ESLint のバージョンが package.json と一致してなさそうなのでちょっと調査します

@Pugma
Copy link
Collaborator

Pugma commented Aug 28, 2024

ん?ESLint 実行時に --cache をつけてキャッシュを効かせようとすると rimraf が必要なのか
少なくとも UI は --cache を消せば通るようになった

でも Dashboard だとこれが有効化されてるのに通ってるな

@nokhnaton
Copy link
Contributor

lint通しておきました~:8bit_sunglasses:

Copy link
Collaborator

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nokhnaton さんありがとうございました!
バージョン更新で依存関係が修正されてそうでしたね

@Pugma Pugma merged commit d1ad60c into main Oct 24, 2024
10 checks passed
@Pugma Pugma deleted the fix/rimraf_uninstall branch October 24, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants