-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/グループ詳細のレイアウトを Figma に揃える #294
Conversation
PR Reviewer Guide 🔍(Review updated until commit 876701a)
|
/review |
/improve |
Persistent review updated to latest commit 876701a |
PR Code Suggestions ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
編集などの traPtitech/Jomon#561 に関わる部分はあとで変更の可能性があることを明示的に残しておきたい気持ちがあります
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
めちゃめちゃ綺麗にレスポンシブ対応されてて感動しました
あ、ごめんなさい、コンフリクトのほうだけお願いします! |
User description
fix: #165
PR Type
Enhancement
Description
Changes walkthrough 📝
GroupBudget.vue
Simplify Group Budget Display
src/components/groupDetail/GroupBudget.vue
GroupDescription.vue
Simplify Group Description Display
src/components/groupDetail/GroupDescription.vue
GroupMembers.vue
Simplify Group Members Display and Authority Check
src/components/groupDetail/GroupMembers.vue
GroupName.vue
Simplify Group Name Editing
src/components/groupDetail/GroupName.vue
SimpleButton
withEditButton
.GroupOwners.vue
Simplify Group Owners Display and Authority Check
src/components/groupDetail/GroupOwners.vue
InputSelectMultiple.vue
Refactor InputSelectMultiple Component
src/components/shared/InputSelectMultiple.vue
GroupDetailPage.vue
Simplify Group Detail Page Layout
src/pages/GroupDetailPage.vue