Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove file saving functionality from Robinhood #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove file saving functionality from Robinhood #55

wants to merge 2 commits into from

Commits on Dec 31, 2020

  1. Remove file saving functionality from Robinhood 

    Rationale:
- Current implementation breaks the serialized loading/saving since the `load` and `save` methods are static but use `this.doNotSaveToDisk` which is not available in a static setting
- Saving (whether to a database, file or otherwise) should be handled by the implementer not the library
- The implementation depends on `fs` which breaks this library's compatibility with `react-native`/`expo`
    @wassgha
    wassgha committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    a3c551c View commit details
    Browse the repository at this point in the history

  2. Updated README.md to reflect the changes

    @wassgha
    wassgha committed Dec 31, 2020
    Configuration menu
    Copy the full SHA
    876dae3 View commit details
    Browse the repository at this point in the history