New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that the taxonomy's rewrite property is not false #117

Open

mseymour wants to merge 2 commits into torounit:master from mseymour:fix-rewrite-when-false

mseymour commented May 2, 2024

If a taxonomy's rewrite property is set to false, in PHP 8 a warning is emitted:

Warning: Trying to access array offset on value of type bool in /var/www/html/http/htdocs/content/plugins/custom-post-type-permalinks/CPTP/Module/Permalink.php on line 421


          Ensure that the taxonomy's rewrite property is not false

70ba4bf

Owner

torounit commented May 16, 2024

@mseymour Nice Catch. Thanks !

torounit reviewed

View reviewed changes

CPTP/Module/Permalink.php Outdated Show resolved Hide resolved


          Update CPTP/Module/Permalink.php

314b3d6

Misnamed variable.

Co-authored-by: Hiroshi Urabe <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet