-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand uv usage in CI #420
Conversation
- uses one `--with` per extra dependency as per https://docs.astral.sh/uv/guides/scripts/#running-a-script-with-dependencies ("Multiple dependencies can be requested by repeating with `--with` option.") - switches the coverage step to uv
since we no longer have the config in pyproject.toml
- reduce sqlite tests as the vast majority of setups are Postgres - add Python 3.13 to CI - use a minimal test for Django 5.0 in tox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding uvx
where I missed it. I have a couple of questions about the testing matrix, otherwise this looks good!
.github/workflows/ci.yml
Outdated
python-version: ['3.9', '3.10', '3.11', '3.12'] | ||
python-version: ['3.12'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: how come we only need to test SQLite only with Python 3.12? Why not 3.13?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brainfart. I reduced the sqlite matrix before I added 3.13. It should be 3.13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Alex Morega <[email protected]>
--with
per extra dependency as per https://docs.astral.sh/uv/guides/scripts/#running-a-script-with-dependencies ("Multiple dependencies can be requested by repeating with--with
option.")