-
-
Notifications
You must be signed in to change notification settings - Fork 177
Testsuite, works. #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Testsuite, works. #339
Conversation
The C version works as an echo server, a milestone past the Python version. |
It's important to get this working so that behavior with the C implementation can easily be compared. This will direct development, ensuring the work being done is done correctly. Currently the C code is being written against my best guess. I'd like to have more awareness about what Tor2web actually does. |
Hey @cheako, from my understanding of the Tor2Web codebase there are no unittests written for the project. The best you can do to interpret proper functionality is run a tor2web node and examine the results. With that said, I think that putting together a set of curl tests against the implementation would be super helpful. python requests would also be a great resource for unittest tor2web functionality |
@NSkelsey In trying to run a tor2web instance but it exits prior to fielding any requests, there is no indication as to why. Instead of doing things by hand I wrote, or rather reused, a script for doing this. This way testing can easily be repeated, by anyone. Please try and identify why this script fails to start tor2web while running on travis.ci, or let me know if it does start and link to your test output. |
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
=========================================
Coverage ? 57.17%
=========================================
Files ? 15
Lines ? 2669
Branches ? 0
=========================================
Hits ? 1526
Misses ? 1143
Partials ? 0
Continue to review full report at Codecov.
|
49963c6
to
3c31643
Compare
7920f58
to
bf26275
Compare
I'm not sure why tor2web exits, it could be that it doesn't like the self signed cert.