-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: projects #85
base: main
Are you sure you want to change the base?
feat: projects #85
Conversation
✅ Successfully deployed to: https://dev.tolocar.org/feat-projects_subpage |
✅ Successfully deployed to: https://dev.tolocar.org/feat-projects_subpage |
src/components/LinkWrapper.tsx
Outdated
@@ -0,0 +1,4 @@ | |||
const LinkWrapper = ({ condition, wrapper, children }) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename the component to ConditionalLinkWrapper
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Agustina-Carrion You still have this on your list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, i'll do this now if you want to continue merging to main. It'll be done in the next minutes
✅ Successfully deployed to: https://dev.tolocar.org/feat-projects_subpage |
✅ Successfully deployed to: https://dev.tolocar.org/feat-projects_subpage |
✅ Successfully deployed to: https://dev.tolocar.org/feat-projects_subpage |
✅ Successfully deployed to: https://dev.tolocar.org/feat-projects_subpage |
✅ Successfully deployed to: https://dev.tolocar.org/feat-projects_subpage |
✅ Successfully deployed to: https://dev.tolocar.org/feat-projects_subpage |
Some things i still need to sort styling wise, for example: project headline is a different vector i need to upload and wide card image background needs some tuning. But the bases are there.
Also, i've used some elements from other PR to start implementation (like: LinkWrapper, ContentTransformer)