Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prost-build): Remove derived(Copy) on boxed fields #1157

Merged
merged 2 commits into from
Sep 20, 2024
Merged

fix(prost-build): Remove derived(Copy) on boxed fields #1157

merged 2 commits into from
Sep 20, 2024

Conversation

ldm0
Copy link
Contributor

@ldm0 ldm0 commented Sep 13, 2024

Fix one of the problems I found while rebasing #705: boxed fields are not Copy

@ldm0 ldm0 force-pushed the boxed_field_cannot_copy branch 2 times, most recently from 6b04f4a to ddd6a33 Compare September 13, 2024 21:57
caspermeijn
caspermeijn requested changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@caspermeijn caspermeijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, basically Config::boxed() is broken in the latest released version because in many circumstances it will derive copy on the manually marked boxed field.

I would like to see a new test that prevents this in the future.

prost-build/src/message_graph.rs Show resolved Hide resolved
@ldm0 ldm0 mentioned this pull request Sep 17, 2024
Open
@ldm0
Copy link
Contributor Author

ldm0 commented Sep 17, 2024

I would like to see a new test that prevents this in the future.

Test added.

caspermeijn
caspermeijn approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@caspermeijn caspermeijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

@caspermeijn caspermeijn added this pull request to the merge queue Sep 20, 2024
Merged via the queue into tokio-rs:master with commit fb977f4 Sep 20, 2024
16 checks passed
@ldm0 ldm0 deleted the boxed_field_cannot_copy branch September 20, 2024 06:19
@caspermeijn caspermeijn mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspermeijn caspermeijn caspermeijn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ldm0 @caspermeijn