Track more mut locations #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonhoo
force-pushed
the
track-more-mut-locations
branch
2 times, most recently
from
2a073bf
to
c0cef54
Compare
carllerche
reviewed
Apr 12, 2020
Rust only allows macros to be used strictly after they have been defined. It's weird, and not needed for this PR, but it will avoid later developers running into the issues I did while developing this.
This doesn't _really_ add any information, since the mut location is the same as the "crated" location. However, when presented with an error with no `mut` location, the user may erroneously believe that there's some mutation they haven't been told about, when the race is really on the construction of the item.
jonhoo
force-pushed
the
track-more-mut-locations
branch
from
c0cef54
to
7d96e7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.