refactor(editor): move viewport renderer to gfx #10338
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #10338 +/- ##
==========================================
+ Coverage 54.31% 54.41% +0.10%
==========================================
Files 2336 2334 -2
Lines 108084 108037 -47
Branches 17848 17845 -3
==========================================
+ Hits 58708 58793 +85
+ Misses 48053 47907 -146
- Partials 1323 1337 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
blocksuite/framework/block-std/src/gfx/viewport/viewport-element.ts
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,2 @@ | |||
| export * from './turbo-renderer.js'; | |||
| export * from './types.js'; | |||
There was a problem hiding this comment.
Unacceptable block specific concept in types.ts
export interface ParagraphLayout {
sentences: SentenceLayout[];
zoom: number;
}There was a problem hiding this comment.
This won't be away very soon, I'll find a workaround to bridge the TurboRenderer with GfxViewportElement.
There was a problem hiding this comment.
You'll need to add extension load point in TurboRenderer, and let paragraph block register add it's only renderer.
This allows referencing it in
GfxViewportElement