Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update publish when push to main #333

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

fix: update publish when push to main #333

wants to merge 30 commits into from

Conversation

scottschreckengaust
Copy link
Contributor

@scottschreckengaust scottschreckengaust commented Feb 13, 2025 •
edited
Loading

Motivation

The code base is more recent than the published version.
Fixes: #299

Proposed Changes

Publish with GitHub actions plus include node@22 in the build.

Test Plan

Instead of triggering the ci.yaml from a non-existent branch "master", use the "main" branch.

@scottschreckengaust
Update ci.yaml
fd0908c 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
Update codeql-analysis.yml
fe8ec3b 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
Update docs.yaml
a12f604 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
Update repolinter.yaml
f68aead 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
Update .tool-versions
4125af5 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
Update CODEOWNERS
23e87c1 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
Update CODEOWNERS
4a77823 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
Update CODEOWNERS
48d24d0 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
Update ci.yaml
82fe648 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
Update ci.yaml
2008c3b 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
Update ci.yaml
efcbbd9 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
Merge branch 'todogroup:main' into feature/update-actions
f0f5d80
@scottschreckengaust
fix: publish release on main
e4dbe8e 
The repository was likely `master` before, but now it is main and therefore hasn't published a release since the renaming.

Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust scottschreckengaust changed the title feat: update actions fix: update publish when push to main Feb 13, 2025
@scottschreckengaust
fix: node22 async fix for setFileContents
c6f35e2 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
fix: async setFileContents
319e387 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
fix: wip removing a test to see if it still works...
052cb69 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
fix: wip don't change the file
c06cd1e 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
fix: prettier failure
bfb5dc4 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
fix: wip make the test for nofile the same
7d1d0c1 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
fix: wip prettier again
ea90bde 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
fix: wip disable getFileContents
bf17509 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
fix: making setFileContents run after getFileContents
4171e5f 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
fix: yet another prettier
419b994 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
fix: wip still node22 issues
6044eed 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
fix: in then catch
a217600 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
fix: add await
900ee37 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
fix: use v24 and v23 node
fc4d34b 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
fix: remove node v24
89c3e11 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
fix: async before
9822db9 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust
fix: prettier first
1261631 
Signed-off-by: Scott Schreckengaust <[email protected]>
@scottschreckengaust scottschreckengaust marked this pull request as ready for review February 14, 2025 04:25
@scottschreckengaust
Copy link
Contributor Author

  • Build when pushed to main.
  • Add node@22 and node@23.
  • Fix tests for node22+ with less lenient async blocks.

NOTE: Please squash commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyandell hyandell Awaiting requested review from hyandell hyandell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cut new version
1 participant
@scottschreckengaust