This repository has been archived by the owner on Apr 17, 2020. It is now read-only.
Prepare type assembler for "Assembler Directives" proposal. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor is intended to make it possible to dynamically construct assemblers in light of the upcoming "Assembler Directives" proposal.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is intended to allow and make it easier to implement part of the "Assembler Directives" (#33) proposal, which would allow defining resource types and assemblers in KDL itself.
This changes adjusts how
kdk::assemblerinstances are created and handled. It no longer requires a subclass, and each assembler can be reused many times. A further bit of work might be to add a "pool" of named assemblers so they can be added to the pool after creation and then called upon when required.