Add $N_ARCH as a default architecture
#832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowspawn
reviewed
Feb 8, 2025
shadowspawn
reviewed
Feb 8, 2025
shadowspawn
reviewed
Feb 8, 2025
README.md
Outdated
| @@ -266,10 +266,15 @@ Another example is the Node.js [unofficial-builds project](https://github.com/no | |||
|
|
|||
| export N_NODE_MIRROR=https://unofficial-builds.nodejs.org/download/release | |||
|
|
|||
| You may need to specify the architecture explicitly if not autodetected by `n`, such as using `musl` `libc` on Alpine: | |||
| You may need to specify the architecture explicitly if not autodetected by `n`, such as using `musl` `libc` on Alpine. You can do that with using `N_ARCH`: | |||
There was a problem hiding this comment.
I think fine to just have N_ARCH covered in example here:
Suggested change
| You may need to specify the architecture explicitly if not autodetected by `n`, such as using `musl` `libc` on Alpine. You can do that with using `N_ARCH`: | |
| You may need to specify the architecture explicitly if not autodetected by `n`, such as using `musl` `libc` on Alpine. You can do that with `N_ARCH` or `--arch`: |
There was a problem hiding this comment.
Combined both, see the new patch which I'll push shortly.
shadowspawn
reviewed
Feb 8, 2025
README.md
Outdated
Comment on lines
276
to
278
| or using `--arch`: | ||
|
|
||
| n --arch x64-musl install lts |
There was a problem hiding this comment.
Can leave out the --arch usage here.
There was a problem hiding this comment.
(Left a comment at the end of the line, to avoid the illusion that both are needed...)
shadowspawn
reviewed
Feb 8, 2025
|
Thanks. Lots of cosmetic comments. I'll do some testing before approving. |
More convenient to use than --arch in case of a mirror with exotic architecture, like the ones in `unofficial-builds`. Do this by making it the default for `$ARCH`. Also, skip the `uname -m` if it's not needed because of this, or because of `--arch`, or the version-specific default. (This is not needed for the functionality.)
elibarzilay
force-pushed
the
add-arch-envvar
branch
from
a5eac0b to
78d09e9
Compare
|
Made all changes. (You might have more comments though, so not to be taken blindly...) |
shadowspawn
added
the
pending release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
More convenient to use than --arch in case of a mirror with exotic architecture, like the ones in
unofficial-builds.Do this by making it the default for
$ARCH.Also, skip the
uname -mif it's not needed because of this, or because of--arch, or the version-specific default. (This is not needed for the functionality.)Problem
See #830.
Solution
The actual fix is just:
The rest are:
$N_ARCHexists if unsetuname -mif$ARCHis set (this could be done in a separate PR)$N_ARCHinshow_diagnosticsChangeLog
New
$N_ARCHto set a default architecture.