Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shopify return location on refunds #6

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Shopify return location on refunds #6

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bb5cfe6
Add Default Return Location Priority
Jun 21, 2024
7de6252
Add Original Return Location to Returns
Jun 21, 2024
db117b1
Add Original location to Refunds
Jun 21, 2024
e67269e
Add original location to creation of credit memos
Jun 21, 2024
adac8cb
Minor cosmetic fixes
Jun 21, 2024
0ba11c1
Syncing with version 25.0.21703.0 (#26811)
JesperSchulz Jul 9, 2024
1b4152d
Merge remote-tracking branch 'origin/main' into ShopifyReturnLocation…
Jul 10, 2024
e94a985
Fix ID Collision
Jul 10, 2024
acb191e
Fix Internal Enum AL0842 Error
Jul 10, 2024
47261f9
Fix Object and Enum Id collision
Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/AL-Go-Settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"runs-on": "windows-latest",
"cacheImageName": "",
"UsePsSession": false,
"artifact": "https://bcinsider-fvh2ekdjecfjd6gk.b02.azurefd.net/sandbox/25.0.20906.0/base",
"artifact": "https://bcinsider-fvh2ekdjecfjd6gk.b02.azurefd.net/sandbox/25.0.21703.0/base",
"country": "base",
"useProjectDependencies": true,
"repoVersion": "25.0",
Expand Down
4 changes: 2 additions & 2 deletions Apps/CH/SwissQRBill/app/src/purchases/SwissQRBillCreateVendBank.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,14 @@ page 11502 "Swiss QR-Bill Create Vend Bank"
TestField(Code);
end;

internal procedure SetDetails(VendorBankAccount: Record "Vendor Bank Account")
procedure SetDetails(VendorBankAccount: Record "Vendor Bank Account")
begin
if Delete() then;
TransferFields(VendorBankAccount);
Insert();
end;

internal procedure GetDetails(var VendorBankAccount: Record "Vendor Bank Account")
procedure GetDetails(var VendorBankAccount: Record "Vendor Bank Account")
begin
VendorBankAccount := Rec;
end;
Expand Down
6 changes: 4 additions & 2 deletions Apps/CZ/AdvancePaymentsLocalization/app/Src/Codeunits/NavigateHandlerCZZ.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ codeunit 31007 "Navigate Handler CZZ"
end;
end;

[EventSubscriber(ObjectType::Page, Page::Navigate, 'OnAfterNavigateShowRecords', '', true, false)]
local procedure NavigateOnAfterNavigateShowRecords(var TempDocumentEntry: Record "Document Entry"; DocNoFilter: Text; PostingDateFilter: Text)
[EventSubscriber(ObjectType::Page, Page::Navigate, 'OnBeforeShowRecords', '', true, false)]
local procedure NavigateOnBeforeShowRecords(var TempDocumentEntry: Record "Document Entry"; DocNoFilter: Text; PostingDateFilter: Text; var IsHandled: Boolean)
var
SalesAdvLetterEntryCZZ: Record "Sales Adv. Letter Entry CZZ";
PurchAdvLetterEntryCZZ: Record "Purch. Adv. Letter Entry CZZ";
Expand All @@ -54,12 +54,14 @@ codeunit 31007 "Navigate Handler CZZ"
SalesAdvLetterEntryCZZ.SetFilter("Document No.", DocNoFilter);
SalesAdvLetterEntryCZZ.SetFilter("Posting Date", PostingDateFilter);
Page.Run(0, SalesAdvLetterEntryCZZ);
IsHandled := true;
end;
Database::"Purch. Adv. Letter Entry CZZ":
begin
PurchAdvLetterEntryCZZ.SetFilter("Document No.", DocNoFilter);
PurchAdvLetterEntryCZZ.SetFilter("Posting Date", PostingDateFilter);
Page.Run(0, PurchAdvLetterEntryCZZ);
IsHandled := true;
end;
end;
end;
Expand Down
25 changes: 13 additions & 12 deletions Apps/CZ/AdvancePaymentsLocalization/app/Src/Codeunits/PurchAdvLetterPostCZZ.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,8 @@ codeunit 31142 "Purch. Adv. Letter-Post CZZ"
TempPurchAdvLetterEntryCZZGlob.InitNewEntry();
TempPurchAdvLetterEntryCZZGlob.InitVendorLedgerEntry(VendorLedgerEntryPayment);
TempPurchAdvLetterEntryCZZGlob.CopyFromGenJnlLine(GenJournalLine);
TempPurchAdvLetterEntryCZZGlob.CopyFromPurchAdvLetterHeader(PurchAdvLetterHeaderCZZ);
TempPurchAdvLetterEntryCZZGlob."Entry Type" := "Advance Letter Entry Type CZZ"::Payment;
TempPurchAdvLetterEntryCZZGlob."Purch. Adv. Letter No." := PurchAdvLetterHeaderCZZ."No.";
EntryNo := TempPurchAdvLetterEntryCZZGlob.InsertNewEntry(not AdvancePostingParametersCZZ."Temporary Entries Only");

if not AdvancePostingParametersCZZ."Temporary Entries Only" then
Expand Down Expand Up @@ -218,8 +218,8 @@ codeunit 31142 "Purch. Adv. Letter-Post CZZ"
TempPurchAdvLetterEntryCZZGlob.InitVendorLedgerEntry(VendorLedgerEntry);
TempPurchAdvLetterEntryCZZGlob.InitRelatedEntry(PurchAdvLetterEntryCZZ);
TempPurchAdvLetterEntryCZZGlob.CopyFromGenJnlLine(GenJournalLine);
TempPurchAdvLetterEntryCZZGlob.CopyFromPurchAdvLetterHeader(PurchAdvLetterHeaderCZZ);
TempPurchAdvLetterEntryCZZGlob."Entry Type" := PurchAdvLetterEntryCZZ."Entry Type";
TempPurchAdvLetterEntryCZZGlob."Purch. Adv. Letter No." := PurchAdvLetterHeaderCZZ."No.";
TempPurchAdvLetterEntryCZZGlob.Cancelled := true;
TempPurchAdvLetterEntryCZZGlob.InsertNewEntry(not AdvancePostingParametersCZZ."Temporary Entries Only");

Expand Down Expand Up @@ -335,8 +335,8 @@ codeunit 31142 "Purch. Adv. Letter-Post CZZ"
TempPurchAdvLetterEntryCZZGlob.InitNewEntry();
TempPurchAdvLetterEntryCZZGlob.InitRelatedEntry(PurchAdvLetterEntryCZZ);
TempPurchAdvLetterEntryCZZGlob.CopyFromGenJnlLine(GenJournalLine);
TempPurchAdvLetterEntryCZZGlob.CopyFromPurchAdvLetterHeader(PurchAdvLetterHeaderCZZ);
TempPurchAdvLetterEntryCZZGlob."Entry Type" := "Advance Letter Entry Type CZZ"::"VAT Payment";
TempPurchAdvLetterEntryCZZGlob."Purch. Adv. Letter No." := PurchAdvLetterHeaderCZZ."No.";
TempPurchAdvLetterEntryCZZGlob."VAT Entry No." := VATEntryNo;
TempPurchAdvLetterEntryCZZGlob."VAT Identifier" := VATPostingSetup."VAT Identifier";
TempPurchAdvLetterEntryCZZGlob."Auxiliary Entry" := AdvancePostingBufferCZZ."Auxiliary Entry";
Expand Down Expand Up @@ -413,8 +413,8 @@ codeunit 31142 "Purch. Adv. Letter-Post CZZ"
TempPurchAdvLetterEntryCZZGlob.InitNewEntry();
TempPurchAdvLetterEntryCZZGlob.InitRelatedEntry(PurchAdvLetterEntryCZZ."Related Entry");
TempPurchAdvLetterEntryCZZGlob.CopyFromGenJnlLine(GenJournalLine);
TempPurchAdvLetterEntryCZZGlob.CopyFromPurchAdvLetterHeader(PurchAdvLetterHeaderCZZ);
TempPurchAdvLetterEntryCZZGlob."Entry Type" := "Advance Letter Entry Type CZZ"::"VAT Payment";
TempPurchAdvLetterEntryCZZGlob."Purch. Adv. Letter No." := PurchAdvLetterHeaderCZZ."No.";
TempPurchAdvLetterEntryCZZGlob."VAT Entry No." := VATEntryNo;
TempPurchAdvLetterEntryCZZGlob."VAT Identifier" := VATPostingSetup."VAT Identifier";
TempPurchAdvLetterEntryCZZGlob."Auxiliary Entry" := AdvancePostingBufferCZZ."Auxiliary Entry";
Expand Down Expand Up @@ -638,6 +638,7 @@ codeunit 31142 "Purch. Adv. Letter-Post CZZ"
PurchAdvLetterHeaderCZZ.Get(PurchAdvLetterEntryCZZ."Purch. Adv. Letter No.");

PurchAdvLetterEntryCZZ2.Reset();
PurchAdvLetterEntryCZZ2.SetRange("Purch. Adv. Letter No.", PurchAdvLetterHeaderCZZ."No.");
PurchAdvLetterEntryCZZ2.SetRange("Document No.", PurchAdvLetterEntryCZZ."Document No.");
PurchAdvLetterEntryCZZ2.SetFilter("Entry Type", '%1|%2|%3',
PurchAdvLetterEntryCZZ2."Entry Type"::"VAT Adjustment",
Expand Down Expand Up @@ -788,8 +789,8 @@ codeunit 31142 "Purch. Adv. Letter-Post CZZ"
TempPurchAdvLetterEntryCZZGlob.InitNewEntry();
TempPurchAdvLetterEntryCZZGlob.InitRelatedEntry(PurchAdvLetterEntryCZZ."Related Entry");
TempPurchAdvLetterEntryCZZGlob.CopyFromGenJnlLine(GenJournalLine);
TempPurchAdvLetterEntryCZZGlob.CopyFromPurchAdvLetterHeader(PurchAdvLetterHeaderCZZ);
TempPurchAdvLetterEntryCZZGlob."Entry Type" := "Advance Letter Entry Type CZZ"::"VAT Payment";
TempPurchAdvLetterEntryCZZGlob."Purch. Adv. Letter No." := PurchAdvLetterHeaderCZZ."No.";
TempPurchAdvLetterEntryCZZGlob."VAT Entry No." := VATEntryNo;
TempPurchAdvLetterEntryCZZGlob."VAT Identifier" := VATPostingSetup."VAT Identifier";
TempPurchAdvLetterEntryCZZGlob."Auxiliary Entry" := AdvancePostingBufferCZZ."Auxiliary Entry";
Expand Down Expand Up @@ -1025,8 +1026,8 @@ codeunit 31142 "Purch. Adv. Letter-Post CZZ"
TempPurchAdvLetterEntryCZZGlob.InitNewEntry();
TempPurchAdvLetterEntryCZZGlob.InitRelatedEntry(PurchAdvLetterEntryCZZ."Related Entry");
TempPurchAdvLetterEntryCZZGlob.CopyFromGenJnlLine(GenJournalLine);
TempPurchAdvLetterEntryCZZGlob.CopyFromPurchAdvLetterHeader(PurchAdvLetterHeaderCZZ);
TempPurchAdvLetterEntryCZZGlob."Entry Type" := PurchAdvLetterEntryCZZ."Entry Type";
TempPurchAdvLetterEntryCZZGlob."Purch. Adv. Letter No." := PurchAdvLetterHeaderCZZ."No.";
TempPurchAdvLetterEntryCZZGlob."VAT Entry No." := VATEntryNo;
TempPurchAdvLetterEntryCZZGlob."VAT Identifier" := VATPostingSetup."VAT Identifier";
TempPurchAdvLetterEntryCZZGlob."Auxiliary Entry" := AdvancePostingBufferCZZ."Auxiliary Entry";
Expand Down Expand Up @@ -1109,8 +1110,8 @@ codeunit 31142 "Purch. Adv. Letter-Post CZZ"
TempPurchAdvLetterEntryCZZGlob.InitVendorLedgerEntry(VendorLedgerEntry);
TempPurchAdvLetterEntryCZZGlob.InitRelatedEntry(PurchAdvLetterEntryCZZ);
TempPurchAdvLetterEntryCZZGlob.CopyFromGenJnlLine(GenJournalLine);
TempPurchAdvLetterEntryCZZGlob.CopyFromPurchAdvLetterHeader(PurchAdvLetterHeaderCZZ);
TempPurchAdvLetterEntryCZZGlob."Entry Type" := PurchAdvLetterEntryCZZ."Entry Type";
TempPurchAdvLetterEntryCZZGlob."Purch. Adv. Letter No." := PurchAdvLetterHeaderCZZ."No.";
TempPurchAdvLetterEntryCZZGlob.Cancelled := true;
EntryNo := TempPurchAdvLetterEntryCZZGlob.InsertNewEntry(not AdvancePostingParametersCZZ."Temporary Entries Only");

Expand Down Expand Up @@ -1269,8 +1270,8 @@ codeunit 31142 "Purch. Adv. Letter-Post CZZ"
TempPurchAdvLetterEntryCZZGlob.InitVendorLedgerEntry(VendorLedgerEntry2);
TempPurchAdvLetterEntryCZZGlob.InitRelatedEntry(PurchAdvLetterEntryCZZ);
TempPurchAdvLetterEntryCZZGlob.CopyFromGenJnlLine(GenJournalLine);
TempPurchAdvLetterEntryCZZGlob.CopyFromPurchAdvLetterHeader(PurchAdvLetterHeaderCZZ);
TempPurchAdvLetterEntryCZZGlob."Entry Type" := "Advance Letter Entry Type CZZ"::Close;
TempPurchAdvLetterEntryCZZGlob."Purch. Adv. Letter No." := PurchAdvLetterHeaderCZZ."No.";
TempPurchAdvLetterEntryCZZGlob."Amount (LCY)" := -RemainingAmountLCY;
EntryNo := TempPurchAdvLetterEntryCZZGlob.InsertNewEntry(not AdvancePostingParametersCZZ."Temporary Entries Only");
end;
Expand Down Expand Up @@ -1416,8 +1417,8 @@ codeunit 31142 "Purch. Adv. Letter-Post CZZ"
TempPurchAdvLetterEntryCZZGlob.InitVendorLedgerEntry(VendorLedgerEntry2);
TempPurchAdvLetterEntryCZZGlob.InitRelatedEntry(PurchAdvLetterEntryCZZ);
TempPurchAdvLetterEntryCZZGlob.CopyFromGenJnlLine(GenJournalLine);
TempPurchAdvLetterEntryCZZGlob.CopyFromPurchAdvLetterHeader(PurchAdvLetterHeaderCZZ);
TempPurchAdvLetterEntryCZZGlob."Entry Type" := "Advance Letter Entry Type CZZ"::Usage;
TempPurchAdvLetterEntryCZZGlob."Purch. Adv. Letter No." := PurchAdvLetterHeaderCZZ."No.";
EntryNo := TempPurchAdvLetterEntryCZZGlob.InsertNewEntry(not AdvancePostingParametersCZZ."Temporary Entries Only");

if PurchAdvLetterHeaderCZZ."Automatic Post VAT Usage" then begin
Expand Down Expand Up @@ -1540,8 +1541,8 @@ codeunit 31142 "Purch. Adv. Letter-Post CZZ"
TempPurchAdvLetterEntryCZZGlob.InitNewEntry();
TempPurchAdvLetterEntryCZZGlob.InitRelatedEntry(RelatedEntryNo);
TempPurchAdvLetterEntryCZZGlob.CopyFromGenJnlLine(GenJournalLine);
TempPurchAdvLetterEntryCZZGlob.CopyFromPurchAdvLetterHeader(PurchAdvLetterHeaderCZZ);
TempPurchAdvLetterEntryCZZGlob."Entry Type" := EntryType;
TempPurchAdvLetterEntryCZZGlob."Purch. Adv. Letter No." := PurchAdvLetterHeaderCZZ."No.";
TempPurchAdvLetterEntryCZZGlob."VAT Entry No." := VATEntryNo;
TempPurchAdvLetterEntryCZZGlob."VAT Identifier" := VATPostingSetup."VAT Identifier";
TempPurchAdvLetterEntryCZZGlob."Auxiliary Entry" := AdvancePostingBufferCZZ."Auxiliary Entry";
Expand Down Expand Up @@ -1719,8 +1720,8 @@ codeunit 31142 "Purch. Adv. Letter-Post CZZ"
TempPurchAdvLetterEntryCZZGlob.InitNewEntry();
TempPurchAdvLetterEntryCZZGlob.InitRelatedEntry(RelatedEntryNo);
TempPurchAdvLetterEntryCZZGlob.CopyFromVATPostingSetup(VATPostingSetup);
TempPurchAdvLetterEntryCZZGlob.CopyFromPurchAdvLetterHeader(PurchAdvLetterHeaderCZZ);
TempPurchAdvLetterEntryCZZGlob."Entry Type" := "Advance Letter Entry Type CZZ"::"VAT Rate";
TempPurchAdvLetterEntryCZZGlob."Purch. Adv. Letter No." := PurchAdvLetterHeaderCZZ."No.";
TempPurchAdvLetterEntryCZZGlob."Document No." := AdvancePostingParametersCZZ."Document No.";
TempPurchAdvLetterEntryCZZGlob."External Document No." := AdvancePostingParametersCZZ."External Document No.";
TempPurchAdvLetterEntryCZZGlob."Posting Date" := AdvancePostingParametersCZZ."Posting Date";
Expand Down Expand Up @@ -1816,8 +1817,8 @@ codeunit 31142 "Purch. Adv. Letter-Post CZZ"
TempPurchAdvLetterEntryCZZGlob.InitRelatedEntry(RelatedEntryNo);
TempPurchAdvLetterEntryCZZGlob.InitDetailedVendorLedgerEntry(RelatedDetEntryNo);
TempPurchAdvLetterEntryCZZGlob.CopyFromVATPostingSetup(VATPostingSetup);
TempPurchAdvLetterEntryCZZGlob.CopyFromPurchAdvLetterHeader(PurchAdvLetterHeaderCZZ);
TempPurchAdvLetterEntryCZZGlob."Entry Type" := "Advance Letter Entry Type CZZ"::"VAT Adjustment";
TempPurchAdvLetterEntryCZZGlob."Purch. Adv. Letter No." := PurchAdvLetterHeaderCZZ."No.";
TempPurchAdvLetterEntryCZZGlob."Document No." := AdvancePostingParametersCZZ."Document No.";
TempPurchAdvLetterEntryCZZGlob."External Document No." := AdvancePostingParametersCZZ."External Document No.";
TempPurchAdvLetterEntryCZZGlob."Posting Date" := AdvancePostingParametersCZZ."Posting Date";
Expand Down
Loading