Dev/gga/shopify v2 #4

GediminasGaubys · 2024-06-20T12:59:40Z

This pull request does not have a related issue as it's part of the delivery for development agreed directly with @AndreiPanko

Here's a quick summary:

Created a report to export Posted Sales Invoices to Shopify as Orders.

Shopify Shop has a new action "Payment Terms Mapping" that takes the user to the new page "Shopify Payment Terms Mapping". Shopify Payment Terms cannot be manually inserted or deleted, they can only be refreshed with an action that pulls them from Shopify. By default FIXED Payment Term is selected as primary during the synchronization of the Payment Terms.
Before Posted Sales Invoices can be synced, a payment term code from Shopify needs to be mapped to the Business Central one or a primary Shopify Payment Term needs to be selected with a Boolean "Is Primary" - this payment term will be used if the Posted Sales Invoice payment terms code doesn't have a mapping to Shopify. This payment term code will also be filled during the sync of Shopify orders.

A new Scope is required. To update payment terms on a draft order – write_payment_terms (read_payment_terms scope was removed because it causes strange behavior - every time a Shopify shop card is opened it states that the scope has changed and requires authorization. write_payment_terms overwrites read_payment_terms). To create a draft order - write_draft_orders.

To export Posted Sales Invoices, here are some conditions that they need to meet:

The new Boolean field "Posted Invoice Sync" needs to be enabled.
The "Shopify Order Id" field on the Posted Sales Invoice needs to be 0.
Posted Sales Invoice "Bill-To Customer" has been mapped to the Shopify Customer or Shopify Companies table.
Posted Sales Invoice "Bill-To Customer" is not a customer used as a Default Customer in the Shopify Shop Card or Shopify Customer Template.
There are no lines of type non-comment (or type is populated but No. is empty).
There are no fraction quantities.
There must be a mapped Payment Terms Code or a selected Primary Payment Terms Code on the new "Shopify Payment Terms Mapping" page.
If there is at least one line of type "Item" where the selected item/variant doesn’t have a link to Shopify Product/Shopify variant and the new Boolean field "Items must be mapped to Products" on the Shopify Shop card is selected - the Posted Sales Invoice will not be exported.
Posted Sales Invoice currency code matches Shopify shop currency code (explanation at the bottom).

If one of the previous conditions is not met, the Posted Sales Invoice "Shopify Order Id" field will be marked with -2. If the GraphQL request fails, then the field will be marked with -1. If everything goes correctly, the field will be filled with the created Shopify Order ID. Users can modify the "Shopify Order Id" field in the posted document (allowed changes from -1 or -2 to 0. The functionality works the same as in the Update Posted Shipment document.)

This export can be executed with a new action that is added to Shopify Shop - "Sync Posted Sales Invoices" or just by running the report "Sync Invoices to Shopify". The draft order in Shopify is created with the values from the Posted Sales Invoice order and lines. If the Remaining Amount of the Posted Sales Invoice is 0, then the order is marked as paid, otherwise, the status will be "Payment pending" and a mapped Payment Terms code will be sent out. After that, the created draft order will be completed and the Shopify order created. All orders are automatically fulfilled. To achieve “paid” status on the Shopify order – use the Manual payment function in the Shopify Order card. Once the report is executed, the Inventory will be synced.

Order sync will import created orders, then check if the order is present in the new Shopify Invoice Header table (this table is filled with the Shopify order ID of the exported Posted Sales Invoice) and if so:

Shopify Order is marked as processed.
A link is added to the Posted Sales Invoice (related documents).

A few details about the mapping of the values and some additional functionality:

All non-comment type lines are exported as custom products (including Items if the new Boolean field "Items must be mapped to Products"** on the Shopify Shop card is not selected).
Taxes from the lines are sent out as a custom product with the title consisting of "VAT Calculation Type" + VAT %.
Invoice discounts from the lines and the header are added up and sent out as a discount to the whole order with the title "Invoice Discount Amount"
Posted Sales Invoice comments are exported as notes.
Once the draft order is completed, an order confirmation email will be sent out to the customer. This functionality is from Shopify itself.
If the product/variant exists in Shopify, the price will be taken from Shopify and not the one in the Posted Sales Invoice line. This is how the draftOrderCreate mutation works.

Out of scope functionalities:

Open orders and open invoices are out of scope.
Fulfillment/Tracking Details.
Refund / partial refund status.
Weight export.

Known issues with different currencies (that's why Posted Sales Invoices with different currencies than Shopify Shop cannot be exported at the moment):

Currently sending out different currencies than the Shopify Shop currency cannot be done because if the currency of the custom product differs from the Shopify shop's currency, the amount sent will still be accepted in the local Shopify shop's currency before being converted to the order's currency. This is why currently if the currency of the posted sales invoice order does not match the Shopify shop currency, the amount will be incorrect. For example, if the VAT amount is 100 GBP, but the Shopify shop's currency is EUR, the custom product will be exported with an amount of 100 GBP. However, this amount will be treated as 100 EUR and then converted to GBP according to the currency exchange rate in Shopify.

Summary by CodeRabbit

New Features
- Added synchronization settings for Shopify with new fields: "Posted Invoice Sync" and "Items Mapped to Products."
- Introduced actions to manage Shopify payment terms and synchronize posted sales invoices.
- Added new enum values for enhanced Shopify GraphQL operations.
- Introduced codeunits for handling draft orders, fulfillment, posted invoice exports, and payment terms synchronization with Shopify.
- New report for syncing invoices to Shopify.
- New table for Shopify Payment Terms management.

coderabbitai · 2024-06-20T13:00:03Z

Walkthrough

The recent updates enhance the integration between the application and Shopify by introducing new fields and actions for invoice synchronization and payment terms mapping. Codeunits for draft orders, fulfillment, posted invoice export, and payment terms API have been added, improving the handling of Shopify-related operations via GraphQL. A new report aids in syncing invoices to Shopify while a dedicated table manages Shopify payment terms, optimizing e-commerce workflow and data consistency.

Changes

Files	Change Summary
`.../Pages/ShpfyShopCard.Page.al`	Added fields for invoice sync and product mapping, and actions for payment terms mapping and invoice sync.
`.../GraphQL/Enums/ShpfyGraphQLType.Enum.al`	Added new enum values for various GraphQL operations related to Shopify transactions and data retrievals.
`.../Invoicing/Codeunits/ShpfyDraftOrdersAPI.Codeunit.al`	Introduced a codeunit for managing draft orders in Shopify through GraphQL.
`.../Invoicing/Codeunits/ShpfyFulfillmentAPI.Codeunit.al`	Added a codeunit for handling Shopify order fulfillment via GraphQL, including creation and retrieval of orders.
`.../Invoicing/Codeunits/ShpfyPostedInvoiceExport.Codeunit.al`	Added a codeunit for exporting posted sales invoices to Shopify along with various utility functions.
`.../Reports/ShpfySyncInvoicesToShpfy.Report.al`	Introduced a report for syncing posted sales invoices from the application to Shopify.
`.../Payments/Codeunits/ShpfyPaymentTermsAPI.Codeunit.al`	Added a codeunit for synchronizing payment terms with Shopify, including pulling and updating payment terms.
`.../Payments/Tables/ShpfyPaymentTerms.Table.al`	Added a table for managing Shopify payment terms with fields defining the terms and associated properties.

Sequence Diagram(s)

sequenceDiagram
    actor User
    participant App as Application
    participant ShpfyAPI as Shopify API

    User->>App: Initiate Sync for Posted Sales Invoices
    App->>ShpfyAPI: Authenticate & Send Export Request
    ShpfyAPI-->>App: Acknowledge & Process Request
    App-->>User: Sync Status and Feedback

    User->>App: Manage Shopify Payment Terms
    App->>ShpfyAPI: Request Payment Terms Data
    ShpfyAPI-->>App: Return Payment Terms Data
    App-->>User: Display/Update Payment Terms

Poem

In a world where e-commerce thrives,
New syncs and mappings come alive.
Orders drafted with seamless care,
Fulfillment swift, no time to spare.
Payment terms in perfect rhyme,
Invoices sync, right on time.
Shopify and app in harmony refine. 🌟🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Apps/W1/Shopify/app/src/GraphQL/Codeunits/ShpfyGQLDraftOrderComplete.Codeunit.al

Apps/W1/Shopify/app/src/Integration/Codeunits/ShpfyAuthenticationMgt.Codeunit.al

Apps/W1/Shopify/app/src/Invoicing/Codeunits/ShpfyDraftOrdersAPI.Codeunit.al

coderabbitai

Actionable comments posted: 14

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1cd5eb1 and e7bbf90.

Files selected for processing (22)

Apps/W1/Shopify/app/src/Base/Pages/ShpfyShopCard.Page.al (4 hunks)
Apps/W1/Shopify/app/src/Base/Tables/ShpfyShop.Table.al (2 hunks)
Apps/W1/Shopify/app/src/GraphQL/Codeunits/ShpfyGQLDraftOrderComplete.Codeunit.al (1 hunks)
Apps/W1/Shopify/app/src/GraphQL/Codeunits/ShpfyGQLFulfillOrder.Codeunit.al (1 hunks)
Apps/W1/Shopify/app/src/GraphQL/Codeunits/ShpfyGQLPaymentTerms.Codeunit.al (1 hunks)
Apps/W1/Shopify/app/src/GraphQL/Enums/ShpfyGraphQLType.Enum.al (1 hunks)
Apps/W1/Shopify/app/src/Integration/Codeunits/ShpfyAuthenticationMgt.Codeunit.al (1 hunks)
Apps/W1/Shopify/app/src/Invoicing/Codeunits/ShpfyDraftOrdersAPI.Codeunit.al (1 hunks)
Apps/W1/Shopify/app/src/Invoicing/Codeunits/ShpfyFulfillmentAPI.Codeunit.al (1 hunks)
Apps/W1/Shopify/app/src/Invoicing/Codeunits/ShpfyPostedInvoiceExport.Codeunit.al (1 hunks)
Apps/W1/Shopify/app/src/Invoicing/Codeunits/ShpfyUpdateSalesInvoice.Codeunit.al (1 hunks)
Apps/W1/Shopify/app/src/Invoicing/PageExt/ShpfySalesInvoiceUpdate.PageExt.al (1 hunks)
Apps/W1/Shopify/app/src/Invoicing/Reports/ShpfyExportInvoiceToShpfy.Report.al (1 hunks)
Apps/W1/Shopify/app/src/Invoicing/Tables/ShpfyInvoiceHeader.Table.al (1 hunks)
Apps/W1/Shopify/app/src/Order handling/Codeunits/ShpfyImportOrder.Codeunit.al (3 hunks)
Apps/W1/Shopify/app/src/Order handling/Codeunits/ShpfyProcessOrder.Codeunit.al (2 hunks)
Apps/W1/Shopify/app/src/Order handling/Tables/ShpfyOrderHeader.Table.al (1 hunks)
Apps/W1/Shopify/app/src/Payments/Codeunits/ShpfyPaymentTermAPI.Codeunit.al (1 hunks)
Apps/W1/Shopify/app/src/Payments/Pages/ShpfyPaymentTermsMapping.Page.al (1 hunks)
Apps/W1/Shopify/app/src/Payments/Tables/ShpfyPaymentTerm.Table.al (1 hunks)
Apps/W1/Shopify/app/src/PermissionSets/ShpfyEdit.PermissionSet.al (2 hunks)
Apps/W1/Shopify/app/src/PermissionSets/ShpfyRead.PermissionSet.al (2 hunks)

Additional comments not posted (24)

Apps/W1/Shopify/app/src/Invoicing/Tables/ShpfyInvoiceHeader.Table.al (1)

1-26: Review of ShpfyInvoiceHeader.Table.al

The table definition for "Shpfy Invoice Header" appears well-defined with proper data classification, a primary key, and a single field for the Shopify Order ID. The use of BigInteger for the "Shopify Order Id" is appropriate given the potentially large values. The table is marked with a Clustered key, which is suitable for performance on the primary identifier.

Data Classification: The use of CustomerContent for data classification is appropriate as it involves customer-specific data.

Primary Key: The choice of "Shopify Order Id" as a primary key is suitable as it should be unique per invoice.

Documentation: The summary documentation is clear and concise, providing a good overview of the table's purpose.

Overall, the table setup seems to align well with the needs of handling Shopify invoice data.

Apps/W1/Shopify/app/src/GraphQL/Codeunits/ShpfyGQLPaymentTerms.Codeunit.al (1)

1-28: Review of ShpfyGQLPaymentTerms.Codeunit.al

This codeunit is well-structured with clear and concise procedures for fetching GraphQL queries and expected costs for payment terms. The GraphQL query is correctly formatted to fetch necessary fields such as id, name, paymentTermsType, dueInDays, and description.

Access Modifier: The use of Internal access is appropriate, ensuring that these procedures are only callable within the application.

Return Types: The procedures correctly return their expected data types, Text for the GraphQL query and Integer for the expected cost.

GraphQL Query: The query is well-formed and targets specific, relevant fields, which should aid in efficient data retrieval.

The implementation is straightforward and aligns with the intended functionality.

Apps/W1/Shopify/app/src/GraphQL/Codeunits/ShpfyGQLFulfillOrder.Codeunit.al (1)

1-27: Review of ShpfyGQLFulfillOrder.Codeunit.al

This codeunit effectively handles the GraphQL operations for fulfilling Shopify orders. The mutation is structured to create fulfillment orders and handle potential user errors.

GraphQL Mutation: The mutation is well-constructed, using placeholders for dynamic data insertion, which is a good practice for reusability and flexibility.

Expected Cost: The specified cost of 10 is noted, and it would be beneficial to ensure this aligns with actual query costs observed in practice, as discussed in previous developer comments.

The structure and implementation are clear, and the internal access modifier is correctly used.

Apps/W1/Shopify/app/src/GraphQL/Codeunits/ShpfyGQLDraftOrderComplete.Codeunit.al (1)

1-27: Review of ShpfyGQLDraftOrderComplete.Codeunit.al

The codeunit is designed to handle the GraphQL operations for completing draft orders in Shopify. The mutation includes comprehensive handling of order details and user errors.

GraphQL Mutation: The mutation is appropriately detailed, including necessary fields and handling multiple orders. The use of placeholders ({{DraftOrderId}}, {{NumberOfOrders}}) enhances the flexibility of the query.

Expected Cost: The cost is set to 15, which should be verified against actual costs to ensure accuracy, as previously discussed by developers.

The codeunit is well-implemented with clear documentation and appropriate internal access control.

Apps/W1/Shopify/app/src/Invoicing/Codeunits/ShpfyUpdateSalesInvoice.Codeunit.al (1)

1-20: Review of ShpfyUpdateSalesInvoice.Codeunit.al

This codeunit provides event handling for updates to sales invoices, specifically focusing on the "Shpfy Order Id". The event subscribers are well-defined, ensuring that changes in the Shopify Order ID are handled correctly.

Event Handling: The use of event subscribers for detecting changes and updating records is a robust method to ensure data consistency.

Logic: The logic to exit early if there is no change (IsChanged) and to update the Shopify Order ID if it differs is straightforward and effective.

The implementation is clear, and the use of local procedures ensures encapsulation of the business logic.

Apps/W1/Shopify/app/src/Payments/Tables/ShpfyPaymentTerm.Table.al (1)

8-64: Table Definition Review for "Shpfy Payment Terms"

The table is well-defined with appropriate data classifications and field attributes. The use of BigInteger for "Id" is suitable for systems expecting a large range of identifiers, which is common in distributed environments like Shopify. Setting fields as non-editable ensures data integrity from the application side, which is a good practice in scenarios involving synchronization with external systems.

However, ensure that the "Shop Code" and "Id" fields are indeed intended to be non-editable as this could impact administrative tasks or data corrections from the UI if needed.

Apps/W1/Shopify/app/src/Payments/Pages/ShpfyPaymentTermsMapping.Page.al (1)

6-70: Review of Page "Shpfy Payment Terms Mapping"

The layout and field setup are appropriate for a mapping page, providing clear information on each payment term. Tooltips are well-used to enhance user understanding.

The "Refresh" action (lines 51-67) is well-implemented, using the ShpfyPaymentTermAPI to pull payment terms, which should help keep the data up-to-date. However, ensure that error handling is robust in the PullPaymentTermsCodes method to handle any issues that might arise during the synchronization process.

Apps/W1/Shopify/app/src/PermissionSets/ShpfyRead.PermissionSet.al (2)

35-35: Addition of Read Permission for "Shpfy Invoice Header"

The addition of the read permission for the "Shpfy Invoice Header" table is aligned with the PR's objective to handle invoicing enhancements. This change allows restricted read access to the invoice header data, which is essential for the new invoicing functionalities introduced.

51-51: Addition of Read Permission for "Shpfy Payment Terms"

The addition of the read permission for the "Shpfy Payment Terms" table supports the new functionality for managing payment terms synchronization with Shopify. This ensures that the necessary data can be accessed in a read-only format where needed.

Apps/W1/Shopify/app/src/PermissionSets/ShpfyEdit.PermissionSet.al (2)

35-35: Addition of Edit Permission for "Shpfy Invoice Header"

The addition of the edit permission for the "Shpfy Invoice Header" table is necessary for the newly introduced invoicing functionalities, allowing for the modification of invoice data directly. This change supports the robust handling of Shopify invoice data within the system.

55-55: Addition of Edit Permission for "Shpfy Payment Terms"

The addition of the edit permission for the "Shpfy Payment Terms" table is crucial for the new functionality allowing the synchronization and management of payment terms with Shopify. This permission enables the necessary modifications to the payment terms data as required by the synchronization process.

Apps/W1/Shopify/app/src/Invoicing/Reports/ShpfyExportInvoiceToShpfy.Report.al (1)

1-98: Comprehensive Review of 'Shpfy Export Invoice to Shpfy' Report

The new report for exporting invoices to Shopify is well-structured and includes necessary error handling, filters, and UI components to facilitate user interaction. The use of dialogues for process updates enhances user experience by providing real-time feedback during the export process. The integration with ShpfyPostedInvoiceExport for actual data handling is correctly implemented. This addition aligns with the invoicing enhancements described in the PR.

Apps/W1/Shopify/app/src/Integration/Codeunits/ShpfyAuthenticationMgt.Codeunit.al (1)

18-18: Updated Scopes in 'Shpfy Authentication Mgt.'

The addition of new scopes such as write_payment_terms and write_draft_orders to the ScopeTxt label is critical for enabling new functionalities that interact with Shopify's API for payment terms and draft orders. This update is necessary for the expanded capabilities described in the PR and ensures that the application has the required permissions to perform these operations.

Apps/W1/Shopify/app/src/GraphQL/Enums/ShpfyGraphQLType.Enum.al (1)

403-417: Addition of New Enum Values for GraphQL Operations

The addition of new enum values for DraftOrderComplete, FulfillOrder, and GetPaymentTerms with their respective implementations links them correctly to the new GraphQL operations. These additions are crucial for supporting the expanded functionalities of the Shopify integration, allowing for more complex operations such as handling draft orders and payment terms synchronization.

Apps/W1/Shopify/app/src/Order handling/Codeunits/ShpfyProcessOrder.Codeunit.al (2)

126-127: Addition of Payment Terms Update Logic

The code for updating payment terms based on Payment Terms Type and Payment Terms Name is a good addition, aligning with the new fields in the Shpfy Order Header table. It's essential to ensure that this new logic integrates correctly with the existing order processing flow.

155-163: Implementation of UpdatePaymentTerms Procedure

The implementation of the UpdatePaymentTerms procedure is concise and correctly uses the SetRange method to filter the Shpfy Payment Terms records. The FindFirst method is used effectively to apply the payment terms code to the sales header. This is a straightforward and efficient way to handle payment terms updates.

Apps/W1/Shopify/app/src/Order handling/Tables/ShpfyOrderHeader.Table.al (1)

730-739: Addition of Payment Terms Fields

The addition of Payment Terms Type and Payment Terms Name fields is a significant enhancement. These fields are essential for better handling and synchronization of payment terms with Shopify, which can be crucial for financial reporting and compliance. Ensure that these new fields are properly integrated and tested in all relevant processes and interfaces where the Shpfy Order Header table is used.

Apps/W1/Shopify/app/src/Base/Tables/ShpfyShop.Table.al (1)

Line range hint 210-210: New fields for product mapping and invoice synchronization added

The addition of the fields "Items Mapped to Products" and "Posted Invoice Sync" aligns with the PR's objective to enhance synchronization capabilities and data handling between the app and Shopify. This is crucial for ensuring data integrity and smooth operation between systems.

Also applies to: 792-798

Apps/W1/Shopify/app/src/Order handling/Codeunits/ShpfyImportOrder.Codeunit.al (2)

125-130: Review the implementation of ShopifyInvoiceExists.

This function checks for the existence of an invoice based on the Shopify order ID. Given its critical role in conditional logic for order processing, it's important to ensure:

Correctness: The function uses the Get method, which is appropriate for checking existence. Ensure that the field "Shopify Order Id" is indexed for performance.

Maintainability: Consider adding a comment explaining what constitutes an invoice's existence and any potential edge cases.

521-522: New fields for payment terms added to the JSON mapping.

The addition of "Payment Terms Type" and "Payment Terms Name" fields to the JSON mapping is crucial for handling payment terms more effectively in imported orders. Ensure the following:

Data Mapping: Verify that these fields are correctly mapped from the JSON object to the OrderHeader record.

Data Validation: Consider validating the data to ensure it meets any expected formats or constraints before insertion.

Apps/W1/Shopify/app/src/Base/Pages/ShpfyShopCard.Page.al (4)

142-147: Added field for Posted Invoice Sync

The addition of the "Posted Invoice Sync" field allows users to specify whether the posted sales invoices can be synchronized to Shopify. This is a beneficial feature for ensuring that financial records between Business Central and Shopify remain consistent. The implementation seems correct and adheres to the application's standards.

254-257: Added field for Items Mapped to Products

The new field "Items Mapped to Products" is designed to control whether only items that are mapped to Shopify products or variants are synchronized from posted sales invoices to Shopify. This field enhances the granularity of sync control, which could be crucial for businesses with complex inventory management needs. The tooltip is clear and the field properties are appropriately set.

664-676: Added action for Payment Terms Mapping

The new action "Payment Terms Mapping" provides a direct way to access and configure the mapping of payment terms between Shopify and Business Central. This is crucial for ensuring that payment terms are correctly synchronized and managed across platforms, which can affect payment schedules and financial reporting. The action is well-placed in the navigation area, making it easily accessible.

1000-1019: Added action for Syncing Posted Sales Invoices

This action enables the synchronization of posted sales invoices to Shopify, which is a significant feature for businesses that need to keep their financial data in sync across both platforms. The conditional enabling of this action based on the "Posted Invoice Sync" field is a good practice as it prevents unintended operations. The implementation of the action including the trigger that runs the "Shpfy Export Invoice to Shpfy" report is correctly done.

Apps/W1/Shopify/app/src/Order handling/Codeunits/ShpfyImportOrder.Codeunit.al

Apps/W1/Shopify/app/src/Invoicing/Codeunits/ShpfyDraftOrdersAPI.Codeunit.al

Apps/W1/Shopify/app/src/Invoicing/Codeunits/ShpfyPostedInvoiceExport.Codeunit.al

Apps/W1/Shopify/app/src/Invoicing/PageExt/ShpfySalesInvoiceUpdate.PageExt.al

Apps/W1/Shopify/app/src/Invoicing/Codeunits/ShpfyFulfillmentAPI.Codeunit.al

Apps/W1/Shopify/app/src/Payments/Codeunits/ShpfyPaymentTermAPI.Codeunit.al

Apps/W1/Shopify/app/src/Invoicing/Codeunits/ShpfyDraftOrdersAPI.Codeunit.al

Apps/W1/Shopify/app/src/Invoicing/Codeunits/ShpfyPostedInvoiceExport.Codeunit.al

Apps/W1/Shopify/app/src/Invoicing/Reports/ShpfyExportInvoiceToShpfy.Report.al

Apps/W1/Shopify/app/src/Payments/Codeunits/ShpfyPaymentTermAPI.Codeunit.al

Apps/W1/Shopify/app/src/PermissionSets/ShpfyEdit.PermissionSet.al