Skip to content

Commit

Permalink
chore!(deps): upgrade to Flutter version 3.10.6 (#78)
Browse files Browse the repository at this point in the history
* fix(deps): update dependency audioplayers to v5

* fix(deps): update dependency http to v1.1.0

* deps(sdk): update to Dart v2.18 and Flutter 3.3.0

* fix(deps): version upgrade to Flutter v3.10.6 including all related package dependencies

* feat: show Artist name of tracks

* chore: rename App in Flutter from MyApp to SoundOnFireApp
  • Loading branch information
timoknapp authored Jul 29, 2023
1 parent e61a0c9 commit 1233fc1
Show file tree
Hide file tree
Showing 23 changed files with 703 additions and 568 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/development.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
- name: Setup Flutter
uses: subosito/flutter-action@v2
with:
flutter-version: '3.0.3'
flutter-version: '3.10.6'
channel: "stable" # or: 'dev' or 'beta'

- name: Prepare & Build
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release_trigger.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
- name: Setup Flutter
uses: subosito/flutter-action@v2
with:
flutter-version: '3.0.3'
flutter-version: '3.10.6'
channel: "stable" # or: 'dev' or 'beta'

- name: Prepare & Build
Expand Down
11 changes: 11 additions & 0 deletions android/app/.project
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,15 @@
<nature>org.eclipse.jdt.core.javanature</nature>
<nature>org.eclipse.buildship.core.gradleprojectnature</nature>
</natures>
<filteredResources>
<filter>
<id>1690353651704</id>
<name></name>
<type>30</type>
<matcher>
<id>org.eclipse.core.resources.regexFilterMatcher</id>
<arguments>node_modules|\.git|__CREATED_BY_JAVA_LANGUAGE_SERVER__</arguments>
</matcher>
</filter>
</filteredResources>
</projectDescription>
12 changes: 11 additions & 1 deletion android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ apply plugin: 'kotlin-android'
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"

android {
compileSdkVersion 31
compileSdkVersion 33

sourceSets {
main.java.srcDirs += 'src/main/kotlin'
Expand Down Expand Up @@ -89,3 +89,13 @@ dependencies {
// implementation 'com.github.javiersantos:AppUpdater:2.7'
implementation 'com.github.MurtadhaS:AppUpdater:2.9'
}

configurations.all {
resolutionStrategy {
eachDependency {
if ((requested.group == "org.jetbrains.kotlin") && (requested.name.startsWith("kotlin-stdlib"))) {
useVersion("1.8.0")
}
}
}
}
2 changes: 1 addition & 1 deletion android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,6 @@ subprojects {
project.evaluationDependsOn(':app')
}

task clean(type: Delete) {
tasks.register("clean", Delete) {
delete rootProject.buildDir
}
4 changes: 2 additions & 2 deletions lib/components/autocomplete_item.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ import 'package:sound_on_fire/util/constants.dart';

class AutocompleteItem extends StatelessWidget {
final String text;
final Function onClick;
final void Function() onClick;

const AutocompleteItem({Key key, this.text, this.onClick}) : super(key: key);
const AutocompleteItem({required Key key, required this.text, required this.onClick}) : super(key: key);

@override
Widget build(BuildContext context) {
Expand Down
40 changes: 20 additions & 20 deletions lib/components/bottom_bar.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,22 @@ import 'package:sound_on_fire/models/Track.dart';
import 'package:sound_on_fire/util/constants.dart';

class BottomBar extends StatelessWidget {
final Function playPause;
final Function backward;
final Function forward;
final Function stop;
final void Function() playPause;
final void Function() backward;
final void Function() forward;
final void Function() stop;
final Track track;
final AudioPlayer audioPlayer;
final Duration currentAudioPosition;

BottomBar({
this.playPause,
this.backward,
this.forward,
this.stop,
this.track,
this.audioPlayer,
this.currentAudioPosition,
required this.playPause,
required this.backward,
required this.forward,
required this.stop,
required this.track,
required this.audioPlayer,
required this.currentAudioPosition,
});

String printDuration() {
Expand Down Expand Up @@ -55,7 +55,7 @@ class BottomBar extends StatelessWidget {
child: SmallButton(
autoFocus: false,
icon: Icon(Icons.fast_rewind),
onClick: track != null ? backward : null,
onClick: track.isNull() ? () {} : backward,
),
),
Expanded(
Expand All @@ -64,14 +64,14 @@ class BottomBar extends StatelessWidget {
icon: Icon(audioPlayer.state != PlayerState.playing
? Icons.play_arrow
: Icons.pause),
onClick: track != null ? playPause : null,
onClick: track.isNull() ? () {} : playPause,
),
),
Expanded(
child: SmallButton(
autoFocus: false,
icon: Icon(Icons.fast_forward),
onClick: track != null ? forward : null,
onClick: track.isNull() ? () {} : forward,
),
),
Expanded(
Expand All @@ -95,15 +95,15 @@ class BottomBar extends StatelessWidget {
flex: 2,
child: Container(
// padding: EdgeInsets.symmetric(horizontal: 5),
child: Text(track != null && currentAudioPosition != null
child: Text(track.isNull() == false && currentAudioPosition != Duration.zero
? printDuration()
: ""),
),
),
Expanded(
flex: 12,
child: Container(
child: track != null && currentAudioPosition != null
child: track.isNull() == false && currentAudioPosition != Duration.zero
? Slider(
value: currentAudioPosition.inSeconds.toDouble(),
min: 0.0,
Expand All @@ -125,7 +125,7 @@ class BottomBar extends StatelessWidget {
),
),
),
track != null
track.isNull() == false
? Expanded(
flex: 2,
child: Container(
Expand All @@ -146,10 +146,10 @@ class BottomBar extends StatelessWidget {
children: <Widget>[
Expanded(
flex: 3,
child: track != null
child: track.isNull() == false
? Container(
child: track.artwork != null
? Image.network(track.artwork)
? Image.network(track.artwork!)
: FlutterLogo(),
)
: Text(""),
Expand All @@ -160,7 +160,7 @@ class BottomBar extends StatelessWidget {
crossAxisAlignment: CrossAxisAlignment.start,
children: <Widget>[
Text(
track != null ? track.title : "",
track.isNull() == false ? track.title : "",
maxLines: 2,
overflow: TextOverflow.ellipsis,
style: const TextStyle(
Expand Down
10 changes: 5 additions & 5 deletions lib/components/input_area.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ import 'package:sound_on_fire/util/constants.dart';

class InputArea extends StatelessWidget {
InputArea({
@required this.autocompleteItems,
@required this.onKeyboardAction,
@required this.isAlphabeticalKeyboard,
@required this.isLoading,
required this.autocompleteItems,
required this.onKeyboardAction,
required this.isAlphabeticalKeyboard,
required this.isLoading,
});

final List<AutocompleteItem> autocompleteItems;
final Function onKeyboardAction;
final Function(String) onKeyboardAction;
final bool isAlphabeticalKeyboard;
final bool isLoading;

Expand Down
Loading

0 comments on commit 1233fc1

Please sign in to comment.