Track invalidations during deserialization #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were printed to the console but not otherwise stored. Storing them allows one to give them more emphasis and perform analysis. With JuliaLang/julia#41913, it becomes possible to attribute them to specific method definitions or deletions. (Of course there might be multiple reasons, but we need to identify at least one in order to make progress.)
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
- Coverage 85.04% 83.55% -1.49%
==========================================
Files 15 15
Lines 1745 1800 +55
==========================================
+ Hits 1484 1504 +20
- Misses 261 296 +35
Continue to review full report at Codecov.
|
|
To really be functional in the tests we'll have to wait for JuliaLang/julia#41913 to hit nightly. But since this hasn't broken anything, I'll merge. |
timholy
added a commit
that referenced
this pull request
Aug 19, 2021
Improves on #260 by collecting all callees and callers and then doing the attribution at once (finding at least one identifiable callee).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were printed to the console but not otherwise stored.
Storing them allows one to give them more emphasis and perform
analysis. With JuliaLang/julia#41913,
it becomes possible to attribute them to specific method
definitions or deletions. (Of course there might be multiple
reasons, but we need to identify at least one in order to make
progress.)
CC @chriselrod, @vtjnash, @ChrisRackauckas. If anyone plans to try this, until 2.8 is released be sure to
dev SnoopCompileCoretoo as it is a separate (subdir) module and there are changes due to #257.