Add test for maritime_boundary #1484
Conversation
nvkelso
changed the title
| self.load_fixtures([ | ||
| 'https://www.openstreetmap.org/relation/148838', | ||
| 'https://www.openstreetmap.org/relation/1428125', | ||
| 'file://integration-test/fixtures/buffered_land/' |
There was a problem hiding this comment.
By hosting the shapefile in a buffered_land directory FixtureTest will set that as the database table name on import.
The way that the shapefile fixtures work at the moment is different from how the OSM URL fixtures work (although it would be better to load them explicitly). Moving the buffered land shapefile into the fixtures directory means it gets loaded automatically.
zerebubuth
force-pushed
the
nvkelso/buffered-land-test
branch
from
5db16cb to
36ad71b
Compare
|
Following 36ad71b, we now have two test failures (rather than the errors we had before). I think these failures represent the actual regressions we have in the code for dealing with maritime boundaries, so in that sense the tests are "working". The code is the next thing we need to fix. |
…ously was set up. Tightened up the filter for maritime `buffered_land` polygons, so it's perhaps a little more obvious where they come from.
|
After c0768c9, test failures just say |
nvkelso
changed the title
|
Circle is happy now! @zerebubuth, can you give a formal review, please? |
| # TODO: either set up new buckets, or deprecate these things. | ||
| #- ./scripts/update-integration-test-coordinates.sh | ||
| #- pip install awscli | ||
| #- aws s3 sync ~/.cache/vector-datasource/ s3://mapzen-tiles-assets/integration-test-fixtures/ --size-only --exclude="*" --include="*.geojson" |
There was a problem hiding this comment.
This one exists now:
In retrospect we should probably call the bucket tilezen-assets instead...
There was a problem hiding this comment.
I don't think it's a big deal to rename it. It's just a matter of updating the getting started instructions and configuration for the shapefile import/prepare processes right?
Update data migrationsUpdate docs