[BACK-2638] Move Summary buckets to collection and unify datastructure #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roukoswarf
force-pushed
the
alex/back-2638-buckets-collection
branch
from
b1bd790 to
73cb386
Compare
Roukoswarf
force-pushed
the
alex/back-2638-buckets-collection
branch
from
73cb386 to
e2d477d
Compare
toddkazakov
reviewed
Feb 7, 2025
data/summary/test/test_suite_test.go
Outdated
| @@ -0,0 +1,13 @@ | |||
| package test_test | |||
There was a problem hiding this comment.
You're breaking the convention here - the test package ought to contain only test helper functions (e.g. to generate data), not actual Ginkgo Tests. Actual tests should be stored next to the file they are testing.
toddkazakov
reviewed
Feb 7, 2025
toddkazakov
reviewed
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.