Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constant-time comparison for the HMAC #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use constant-time comparison for the HMAC #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libthumbor/url_signers/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
# Copyright (c) 2011 globo.com [email protected]

from six import text_type
import secrets


class BaseUrlSigner:
Expand All @@ -19,7 +20,7 @@ def __init__(self, security_key):

def validate(self, actual_signature, url):
url_signature = self.signature(url)
return url_signature == actual_signature
return secrets.compare_digest(url_signature, actual_signature)

def signature(self, url):
raise NotImplementedError()