Update jsng-ci.yml to use multiple ubuntu versions #536
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
running ci workflow on Ubuntu 20.0, Ubuntu 18.04 and Ubuntu 16.04
sameh-farouk
requested review from
abom,
AhmedHanafy725,
m-motawea,
rkhamis,
waleedhammam and
xmonader
as code owners
Codecov Report
@@ Coverage Diff @@
## development actions/toolkit#536 +/- ##
===============================================
+ Coverage 70.18% 70.36% +0.18%
===============================================
Files 84 84
Lines 3820 3820
===============================================
+ Hits 2681 2688 +7
+ Misses 1139 1132 -7
Continue to review full report at Codecov.
|
- including additional values into combinations - Prevents a workflow run from failing when a job fails only for experimental jobs with both ubuntu 20.04 and python 3.9 - prevent GitHub cancels all in-progress jobs if any matrix job fails. to allow us to know the results for all jobs, even if one fails. - maximize the number of jobs that can run simultaneously when using a matrix job strategy.
adding names to experimental jobs.
netstat not available in recent Ubuntu versions. it is not installed by default and considered deprecated in favor of the modern ss command. as some tests used netstat, this commit bing it back by installing net-tools utilities
AhmedHanafy725
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as currently, our CI build fails on ubuntu 20.04, this PR makes these changes to our workflow (fix the issue and also introduce important improvements):
Related Issues
actions/toolkit#535
actions/toolkit#540
actions/toolkit#521
Important note regard PR checks failing on CI:
the main idea to use continue-on-error is that if an allowed job failure fails (such as in the case of experimental jobs in this workflow), it means that that job should get a red X, but the overall workflow should not.
however, on the PR page, it's rather confusing, and it looks like the CI broke when it did not and actually the whole workflow is still marked as successful when looking in the Actions tab (see the screenshot).
this is because of an ongoing open issue on GitHub Actions repo: actions/runner#2347. so we can merge this PR and benefit from the improvements of the suggested CI workflow and - for now - ignore the UI indication in the PR page as the main jobs passed, and only experimental job/s was failed.