Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos in documentation files #672

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: typos in documentation files #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8206263
Update signatureMint.md
leopardracer Nov 14, 2024
3a1c4db
Update marketplace.md
leopardracer Nov 14, 2024
a2f4d5a
Merge branch 'main' into main
leopardracer Dec 12, 2024
2dedbdb
Merge branch 'main' into main
leopardracer Mar 8, 2025
db3c113
Merge branch 'main' into main
leopardracer Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/prebuilts/marketplace-legacy/marketplace.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ The document is written for technical and non-technical readers. To ask further
---
## Background

The [thirdweb](https://thirdweb.com/) `Marketplace` is a market where where people can sell NFTs — [ERC 721](https://eips.ethereum.org/EIPS/eip-721) or [ERC 1155](https://eips.ethereum.org/EIPS/eip-1155) tokens — at a fixed price ( what we'll refer to as a "Direct listing"), or auction them (what we'll refer to as an "Auction listing").
The [thirdweb](https://thirdweb.com/) `Marketplace` is a market where people can sell NFTs — [ERC 721](https://eips.ethereum.org/EIPS/eip-721) or [ERC 1155](https://eips.ethereum.org/EIPS/eip-1155) tokens — at a fixed price ( what we'll refer to as a "Direct listing"), or auction them (what we'll refer to as an "Auction listing").

### Direct Listings
An NFT owner (or 'lister') can list their NFTs for sale at a fixed price. A potential buyer can buy the NFT for the specified price, or make an offer to buy the listed NFTs for a different price or currency, which the lister can choose to accept.
Expand Down
6 changes: 3 additions & 3 deletions contracts/prebuilts/token/signatureMint.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Any external party can then present a smart contract implementing the 'signature

The following diagram illustrates how the 'signature minting' flow looks like. For example, consider a webapp like [wombo.art](https://www.wombo.art/) which lets a user generate artwork on its website. Once a user has generated artwork on the wombo website, wombo can allow the user to mint their generated artwork as an NFT on wombo's own contract, where wombo can ensure that what the user will mint on wombo's contract is the intended generated artwork.

![signaute-minting-diagram-1.png](/assets/signature-minting-diag-1.png)
![signature-minting-diagram-1.png](/assets/signature-minting-diag-1.png)

### Why we're developing `Signature Minting`

Expand Down Expand Up @@ -91,10 +91,10 @@ function mintWithSignature(MintRequest calldata req, bytes calldata signature) e
| req | The payload / mint request. |
| signature | The signature produced by an account signing the mint request. |

The contract implementing the 'signature minting' mechanism first recover's the address of the signer from the given payload i.e. `req` and the `signature`, and verifies that an authorized address has signed off this incoming mint request.
The contract implementing the 'signature minting' mechanism first recovers the address of the signer from the given payload i.e. `req` and the `signature`, and verifies that an authorized address has signed off this incoming mint request.

Once verified, tokens are minted according to the information specified in the payload.

## Authors
- [nkrishang](https://github.com/nkrishang)
- [thirdweb team](https://github.com/thirdweb-dev)
- [thirdweb team](https://github.com/thirdweb-dev)