Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite of BMC to BayesQuad and MonteCarlo to PriorSampling #11

Merged
merged 9 commits into from
Feb 15, 2021
Merged

Rewrite of BMC to BayesQuad and MonteCarlo to PriorSampling #11

merged 9 commits into from
Feb 15, 2021

Conversation

theogf
Copy link
Owner

@theogf theogf commented Feb 15, 2021 •
edited
Loading

Restructuration of the code:

  • AbstractIntegrator -> AbstractBayesQuad
  • BMC -> BayesQuad
  • MonteCarlo -> PriorSampling
  • BayesQuad now directly contains the lengthscale and variance of the prior
  • Instead of having a bayesquad function, the BayesQuad function acts directly as a function
  • calc_z and calc_C now depends directly of BayesQuad

Fixes #10

johannesgiersdorf
johannesgiersdorf approved these changes Feb 15, 2021
View reviewed changes
Copy link
Collaborator

@johannesgiersdorf johannesgiersdorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@johannesgiersdorf johannesgiersdorf merged commit d15bd0a into main Feb 15, 2021
@theogf theogf deleted the tg/redefine_integrator branch February 15, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johannesgiersdorf johannesgiersdorf johannesgiersdorf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename BMC
2 participants
@theogf @johannesgiersdorf