Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SEO docs for PR #1515 #93

Open
wants to merge 2 commits into
base: source
Choose a base branch
from
Open

Conversation

PMExtra
Copy link

@PMExtra PMExtra commented May 28, 2020

@CLAassistant
Copy link

CLAassistant commented May 28, 2020

CLA assistant check
All committers have signed the CLA.

@PMExtra PMExtra changed the title Update SSO docs for PR #1515 Update SEO docs for PR #1515 May 28, 2020
Comment on lines 22 to 23
robots: noimageindex, nofollow, nosnippet
noindex: true # This will be ignored if you've set the robots.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, these two parameters can not be used at the same time, here may mislead the user. May be split to explain that it would be better.

Copy link
Author

@PMExtra PMExtra May 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for my poor English. I'm not sure how to explain it so I just provided an example with comment.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其实正常的逻辑应该是,先说 robots: ,然后再说 noindex: truerobots: noindex 的一个 convenience 。

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其实倒也没有必要非得支持 noindex: true ,只是之前看到有别人用了 noindex: true 这种写法了,觉得保持兼容会门槛低一点,也省得普通用户去理解 robots 的那堆 noimageindex, nofollow, nosnippet 之类的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants