Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intent classification using Ludwig #67

Closed
wants to merge 4 commits into from
Closed

Intent classification using Ludwig #67

wants to merge 4 commits into from

Conversation

SubhradeepSS
Copy link

@SubhradeepSS SubhradeepSS commented Apr 11, 2020 •
edited
Loading

Issues handled: #58 #57

@SubhradeepSS SubhradeepSS changed the title Text classification using Ludwig Intent classification using Ludwig Apr 11, 2020
@SubhradeepSS
Copy link
Author

@TeAmP0is0N This is the folder I added in which the notebook as well as the dataset used is present.
Please review those and let me know.

@SubhradeepSS
Copy link
Author

@TeAmP0is0N This is the folder I added in which the notebook as well as the dataset used is present.
Please review those and let me know.

@TeAmP0is0N Did u check?

RohitRathore1
RohitRathore1 suggested changes Apr 15, 2020
View reviewed changes
Copy link
Member

@RohitRathore1 RohitRathore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SubhradeepSS Take more datasets like this and work on those datasets.

@SubhradeepSS
Copy link
Author

@SubhradeepSS Take more datasets like this and work on those datasets.

Will the PR be merged after working on all datasets?

@RohitRathore1
Copy link
Member

Yes, your PR will merge.

@SubhradeepSS
Copy link
Author

Yes, your PR will merge.
@TeAmP0is0N
Upto how many datasets do I need to work on?Shouldn't the PRs be separately merged for every dataset as this will count towards gssoc score?Please correct me if I am wrong

@RohitRathore1
Copy link
Member

@SubhradeepSS No, you should not create diff PR. You can add upto total 5 datasets in a PR.

@RohitRathore1
Copy link
Member

Issues handled: #58 #57

You are handling only issue no #58 right now. So mention only #58.

@SubhradeepSS
Copy link
Author

SubhradeepSS commented Apr 17, 2020 •
edited
Loading

Issues handled: #58 #57

You are handling only issue no #58 right now. So mention only #58.

@TeAmP0is0N Did u check my notebook?I have also worked on #57

@RohitRathore1
Copy link
Member

RohitRathore1 commented Apr 18, 2020 •
edited
Loading

@SubhradeepSS yes, I checked your PR. in related to issue no #57 there will be more issue. #57 is the base for intent classification. For now you are working only on Datasets.

@swapagarwal
Copy link
Member

Needs more work to integrate with the bot. Can't be merged as-is.

@swapagarwal swapagarwal marked this pull request as draft June 1, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RohitRathore1 RohitRathore1 RohitRathore1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SubhradeepSS @RohitRathore1 @swapagarwal