Input #2059
Merged
Input #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e0e2ed2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-2059.the-guild-docs-storybook.pages.dev |
jdolle
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jdolle caught my lazy content swap on form error :P so this PR adds a proper Input for the Hive landing pages, with a message colored as error warning or a positive text
I drafted a simple design in Figma here: https://www.figma.com/design/hd9u9tqzSSgkkI1r1SmjTF/The-Guild%3A-Working-File?node-id=4837-1118&t=BEkc9l22mOfeTEGH-0
but in the code I ended up using lower opacity colors from the landing page (we had positive, critical and warning tones from the comparison tables already)
I'm open to adding an exclamation mark icon, but I didn't find anything that looked good.