fix(deps): update rust crate url to v2.5.4 #621

renovate · 2024-11-27T05:03:46Z

This PR contains the following updates:

Package	Type	Update	Change
url	dependencies	patch	`2.5.2` -> `2.5.4`

Release Notes

servo/rust-url (url)

`v2.5.4`

Compare Source

What's Changed

Revert "Normalize URL paths: convert /.//p, /..//p, and //p to p (#943)" by @valenting in https://github.com/servo/rust-url/pull/999
Updates the MSRV to 1.63 required though the libc v0.2.164 dependency

Full Changelog: servo/rust-url@v2.5.3...v2.5.4

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

github-actions · 2024-11-27T05:04:23Z

🚨 Rust Panic Audit: 342 Potential Panic Points Detected 🚨

Crate: ``

📊 Total Usages: 239

🔢 array_index usages: 31
🎁 unwrap usages: 159
🔎 expect usages: 41
🚨 panic usages: 8

Crate: `federation_query_planner`

📊 Total Usages: 50

🎁 unwrap usages: 29
🔎 expect usages: 8
🚨 panic usages: 3
🔢 array_index usages: 10

Crate: `common`

📊 Total Usages: 11

🎁 unwrap usages: 10
🔢 array_index usages: 1

Crate: `conductor`

📊 Total Usages: 11

🚨 panic usages: 2
🔎 expect usages: 7
🎁 unwrap usages: 2

Crate: `cloudflare_worker`

📊 Total Usages: 8

🔎 expect usages: 2
🎁 unwrap usages: 5
🚨 panic usages: 1

Crate: `engine`

📊 Total Usages: 7

🎁 unwrap usages: 6
🔎 expect usages: 1

Crate: `telemetry`

📊 Total Usages: 7

🎁 unwrap usages: 3
🔢 array_index usages: 4

Crate: `tracing`

📊 Total Usages: 6

🔎 expect usages: 1
🎁 unwrap usages: 5

Crate: `config`

📊 Total Usages: 3

🎁 unwrap usages: 2
🚨 panic usages: 1

📌 Expected Annotations

Crate: `napi`

📊 Total Expected Usages: 1

expand details

Reason: "we need this"

Code: panic!("Exited process!")
Location: ./libs/napi/src/lib.rs:18

Crate: `conductor`

📊 Total Expected Usages: 2

expand details

Reason: "we need to exit the process, if the logger can't be correctly set."

Code: let _guard = tracing::subscriber::set_default(subscriber);
Location: ./bin/conductor/src/lib.rs:64

Reason: "we need to exit the process, if the provided configuration file is incorrect."

Code: panic!("Failed to initialize gateway: {:?}", e);
Location: ./bin/conductor/src/lib.rs:103

Crate: `engine`

📊 Total Expected Usages: 2

expand details

Reason: "if we are unable to construct the endpoints and attach them onto the gateway's http server, we have to exit"

Code: Err(e) => panic!("failed to construct endpoint: {:?}", e),
Location: ./libs/engine/src/gateway.rs:158

Reason: "we can safely index here, it's inside a test with constant defined fixtures."

Code: ConductorGateway::execute(request, &gw.routes[0].route_data).await
Location: ./libs/engine/src/gateway.rs:190

Crate: `common`

📊 Total Expected Usages: 1

expand details

Reason: "we're parsing a statically defined constant, we know it works ;)"

Code: .unwrap()
Location: ./libs/common/src/graphql.rs:31

Crate: ``

📊 Total Expected Usages: 22

expand details

Reason: "if we are unable to construct the endpoints and attach them onto the gateway's http server, we have to exit"

Code: Err(e) => panic!("failed to construct endpoint: {:?}", e),
Location: ./libs/engine/src/gateway.rs:158

Reason: "we can safely index here, it's inside a test with constant defined fixtures."

Code: ConductorGateway::execute(request, &gw.routes[0].route_data).await
Location: ./libs/engine/src/gateway.rs:190

Reason: "we're parsing a statically defined constant, we know it works ;)"

Code: .unwrap()
Location: ./libs/common/src/graphql.rs:31

Reason: "we need this"

Code: panic!("Exited process!")
Location: ./libs/napi/src/lib.rs:18

Reason: "part of development docgen CLI"

Code: .expect("Failed to serialize json schema for config file!");
Location: ./libs/config/src/generate-json-schema.rs:50

Reason: "part of development docgen CLI"

Code: .expect("Failed to write the json schema to the file system!");
Location: ./libs/config/src/generate-json-schema.rs:54

Reason: "👇"

Code: let raw_contents = read_to_string(file_path)
Location: ./libs/config/src/lib.rs:815

Reason: "👇"

Code: panic!("Failed to interpolate config file, please resolve the above errors");
Location: ./libs/config/src/lib.rs:847

Reason: "👇"

Code: parse_config_from_json(&config_string).expect("Failed to parse JSON config file")
Location: ./libs/config/src/lib.rs:854

Reason: "👇"

Code: parse_config_from_yaml(&config_string).expect("Failed to parse YAML config file")
Location: ./libs/config/src/lib.rs:858

Reason: "👇"

Code: _ => panic!("Unsupported config file extension"),
Location: ./libs/config/src/lib.rs:875

Reason: "👇"

Code: None => panic!("Config file has no extension"),
Location: ./libs/config/src/lib.rs:878

Reason: "statically defined regex pattern, we know it works ;)"

Code: .unwrap();
Location: ./libs/config/src/interpolate.rs:18

Reason: "we need to exit the process, if the logger can't be correctly set."

Code: let _guard = tracing::subscriber::set_default(subscriber);
Location: ./bin/conductor/src/lib.rs:64

Reason: "we need to exit the process, if the provided configuration file is incorrect."

Code: panic!("Failed to initialize gateway: {:?}", e);
Location: ./bin/conductor/src/lib.rs:103

Reason: "it panics only if the header name is not valid, and we know it is."

Code: .unwrap()
Location: ./bin/cloudflare_worker/src/http_tracing.rs:20

Reason: "it panics only if the URL source is not valid, and it's already validated before."

Code: let url = req.url().unwrap();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:23

Reason: "it only panics if we are not running in a CF context, should be safe."

Code: let cf_info = req.cf().unwrap();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:27

Reason: "unwraps only in special cases where "data:text" is used."

Code: let http_host = url.host().unwrap().to_string();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:36

Reason: "if initiating an http client fails, then we have to exit."

Code: let client = wasm_polyfills::create_http_client().build().unwrap();
Location: ./plugins/jwt_auth/src/jwks_provider.rs:49

Reason: "if the provided VRL code in the config file can't compile, we have to exit."

Code: panic!("failed to compile vrl program");
Location: ./plugins/vrl/src/plugin.rs:129

Reason: "states is a non-user provided variable"

Code: .expect("can't merge states when states is an empty vector!")
Location: ./plugins/vrl/src/plugin.rs:146

Crate: `jwt_auth`

📊 Total Expected Usages: 1

expand details

Reason: "if initiating an http client fails, then we have to exit."

Code: let client = wasm_polyfills::create_http_client().build().unwrap();
Location: ./plugins/jwt_auth/src/jwks_provider.rs:49

Crate: `vrl`

📊 Total Expected Usages: 2

expand details

Reason: "if the provided VRL code in the config file can't compile, we have to exit."

Code: panic!("failed to compile vrl program");
Location: ./plugins/vrl/src/plugin.rs:129

Reason: "states is a non-user provided variable"

Code: .expect("can't merge states when states is an empty vector!")
Location: ./plugins/vrl/src/plugin.rs:146

Crate: `config`

📊 Total Expected Usages: 9

expand details

Reason: "part of development docgen CLI"

Code: .expect("Failed to serialize json schema for config file!");
Location: ./libs/config/src/generate-json-schema.rs:50

Reason: "part of development docgen CLI"

Code: .expect("Failed to write the json schema to the file system!");
Location: ./libs/config/src/generate-json-schema.rs:54

Reason: "👇"

Code: let raw_contents = read_to_string(file_path)
Location: ./libs/config/src/lib.rs:815

Reason: "👇"

Code: panic!("Failed to interpolate config file, please resolve the above errors");
Location: ./libs/config/src/lib.rs:847

Reason: "👇"

Code: parse_config_from_json(&config_string).expect("Failed to parse JSON config file")
Location: ./libs/config/src/lib.rs:854

Reason: "👇"

Code: parse_config_from_yaml(&config_string).expect("Failed to parse YAML config file")
Location: ./libs/config/src/lib.rs:858

Reason: "👇"

Code: _ => panic!("Unsupported config file extension"),
Location: ./libs/config/src/lib.rs:875

Reason: "👇"

Code: None => panic!("Config file has no extension"),
Location: ./libs/config/src/lib.rs:878

Reason: "statically defined regex pattern, we know it works ;)"

Code: .unwrap();
Location: ./libs/config/src/interpolate.rs:18

Crate: `cloudflare_worker`

📊 Total Expected Usages: 4

expand details

Reason: "it panics only if the header name is not valid, and we know it is."

Code: .unwrap()
Location: ./bin/cloudflare_worker/src/http_tracing.rs:20

Reason: "it panics only if the URL source is not valid, and it's already validated before."

Code: let url = req.url().unwrap();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:23

Reason: "it only panics if we are not running in a CF context, should be safe."

Code: let cf_info = req.cf().unwrap();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:27

Reason: "unwraps only in special cases where "data:text" is used."

Code: let http_host = url.host().unwrap().to_string();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:36

github-actions · 2024-11-27T05:11:51Z

🐋 This PR was built and pushed to the following Docker images:

Docker Bake metadata

{
"conductor": {
  "buildx.build.provenance": {
    "buildType": "https://mobyproject.org/buildkit@v1",
    "materials": [
      {
        "uri": "pkg:docker/[email protected]?platform=linux%2Famd64",
        "digest": {
          "sha256": "a92ed51e0996d8e9de041ca05ce623d2c491444df6a535a566dabd5cb8336946"
        }
      },
      {
        "uri": "pkg:docker/[email protected]?platform=linux%2Famd64",
        "digest": {
          "sha256": "83101f6985c93e1e6501b3375de188ee3d2cbb89968bcc91611591f9f447bd42"
        }
      }
    ],
    "invocation": {
      "configSource": {
        "entryPoint": "Dockerfile"
      },
      "parameters": {
        "frontend": "dockerfile.v0",
        "args": {
          "label:org.opencontainers.image.authors": "The Guild <[email protected]>",
          "label:org.opencontainers.image.description": "Conductor is a robust GraphQL Gateway.",
          "label:org.opencontainers.image.docs": "https://the-guild.dev/graphql/gateway",
          "label:org.opencontainers.image.licenses": "MIT",
          "label:org.opencontainers.image.revision": "dd74db69d37471c0ee767a1420a95f790ccecf41",
          "label:org.opencontainers.image.source": "https://github.com/the-guild-org/conductor",
          "label:org.opencontainers.image.title": "Conductor",
          "label:org.opencontainers.image.url": "https://the-guild.dev/graphql/gateway",
          "label:org.opencontainers.image.vendor": "The Guild",
          "label:org.opencontainers.image.version": ""
        },
        "locals": [
          {
            "name": "context"
          },
          {
            "name": "dockerfile"
          }
        ]
      },
      "environment": {
        "platform": "linux/amd64"
      }
    }
  },
  "buildx.build.ref": "builder-19c00908-64b1-4950-b8dd-19d9114f1a4a/builder-19c00908-64b1-4950-b8dd-19d9114f1a4a0/okene9v50v7kfykt3y3roq0t9",
  "containerimage.config.digest": "sha256:340e78faf37f20769f6c34457cae381b316fba30108e858f5d67997e69009d95",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
    "digest": "sha256:f599ebba867a8278d8e8bfb778c4813529ffbd56859e015ac8028a46712d4971",
    "size": 902,
    "platform": {
      "architecture": "amd64",
      "os": "linux"
    }
  },
  "containerimage.digest": "sha256:f599ebba867a8278d8e8bfb778c4813529ffbd56859e015ac8028a46712d4971",
  "image.name": "ghcr.io/the-guild-org/conductor/conductor:dd74db69d37471c0ee767a1420a95f790ccecf41"
}
}

github-actions · 2024-11-27T05:12:57Z

✅ Benchmark Results

     data_received..................: 13 MB   221 kB/s
     data_sent......................: 22 MB   363 kB/s
     http_req_blocked...............: min=1.28µs   avg=3µs      med=2.28µs   max=992.02µs p(95)=3.32µs   p(99)=7.96µs  
     http_req_connecting............: min=0s       avg=344ns    med=0s       max=388.6µs  p(95)=0s       p(99)=0s      
     http_req_duration..............: min=319.07µs avg=410.27µs med=387.73µs max=11.6ms   p(95)=490.28µs p(99)=571.16µs
       { expected_response:true }...: min=319.07µs avg=410.27µs med=387.73µs max=11.6ms   p(95)=490.28µs p(99)=571.16µs
     ✓ { scenario:rps_1000 }........: min=319.07µs avg=410.27µs med=387.73µs max=11.6ms   p(95)=490.28µs p(99)=571.16µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 60001
     ✓ { scenario:rps_1000 }........: 0.00%   ✓ 0           ✗ 60001
     http_req_receiving.............: min=10.08µs  avg=27.1µs   med=26µs     max=4.48ms   p(95)=35.41µs  p(99)=47.34µs 
     http_req_sending...............: min=6.87µs   avg=15.09µs  med=14.2µs   max=1.7ms    p(95)=20.57µs  p(99)=31.63µs 
     http_req_tls_handshaking.......: min=0s       avg=0s       med=0s       max=0s       p(95)=0s       p(99)=0s      
     http_req_waiting...............: min=278.56µs avg=368.07µs med=346.75µs max=11.53ms  p(95)=446.16µs p(99)=524.26µs
     http_reqs......................: 60001   1000.005116/s
     ✓ { scenario:rps_1000 }........: 60001   1000.005116/s
     iteration_duration.............: min=394.99µs avg=501.38µs med=476.77µs max=12.2ms   p(95)=587.84µs p(99)=723.95µs
     iterations.....................: 60001   1000.005116/s
     ✓ { scenario:rps_1000 }........: 60001   1000.005116/s
     valid_graphql_response.........: 100.00% ✓ 60001       ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001       ✗ 0    
     valid_http_code................: 100.00% ✓ 60001       ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001       ✗ 0    
     vus............................: 1       min=0         max=2  
     vus_max........................: 200     min=200       max=200

fix(deps): update rust crate url to v2.5.4

dd74db6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(deps): update rust crate url to v2.5.4 #621

fix(deps): update rust crate url to v2.5.4 #621

renovate bot commented Nov 27, 2024

github-actions bot commented Nov 27, 2024

github-actions bot commented Nov 27, 2024

github-actions bot commented Nov 27, 2024

fix(deps): update rust crate url to v2.5.4 #621

Are you sure you want to change the base?

fix(deps): update rust crate url to v2.5.4 #621

Conversation

renovate bot commented Nov 27, 2024

Release Notes

v2.5.4

What's Changed

v2.5.3

What's Changed

New Contributors

Configuration

github-actions bot commented Nov 27, 2024

🚨 Rust Panic Audit: 342 Potential Panic Points Detected 🚨

Crate: ``

Crate: federation_query_planner

Crate: common

Crate: conductor

Crate: cloudflare_worker

Crate: engine

Crate: telemetry

Crate: tracing

Crate: config

📌 Expected Annotations

Crate: napi

Crate: conductor

Crate: engine

Crate: common

Crate: ``

Crate: jwt_auth

Crate: vrl

Crate: config

Crate: cloudflare_worker

github-actions bot commented Nov 27, 2024

github-actions bot commented Nov 27, 2024

✅ Benchmark Results

`v2.5.4`

`v2.5.3`

Crate: `federation_query_planner`

Crate: `common`

Crate: `conductor`

Crate: `cloudflare_worker`

Crate: `engine`

Crate: `telemetry`

Crate: `tracing`

Crate: `config`

Crate: `napi`

Crate: `conductor`

Crate: `engine`

Crate: `common`

Crate: `jwt_auth`

Crate: `vrl`

Crate: `config`

Crate: `cloudflare_worker`