Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bb/bootstrap integration #45

Merged
merged 10 commits into from
Sep 29, 2024
Merged

Bb/bootstrap integration #45

merged 10 commits into from
Sep 29, 2024

Conversation

bbland1
Copy link
Collaborator

@bbland1 bbland1 commented Sep 25, 2024

Description

We discussed using bootstrap and react-bootstap in the application this installs them and changes our buttons, inputs, navbar to utilize it. Makes sure the app still looks and functions the same with the bootstrap default styling basically.

Acceptance Criteria

  • A working and functioning app that uses the new package 😅

Type of Changes

Type
💄 Style

Updates

Before

Screenshot 2024-09-25 at 7 06 50 PM

After

Screenshot 2024-09-25 at 7 06 59 PM

Testing Steps / QA Criteria

  • Opening the preview link in the PR you should see the changes

To make sure the dependencies and code function as should:

  • From your terminal, pull down this branch with git pull origin bb/bootstrap-integration and check that branch out with git checkout `bb/bootstrap-integration``
  • Then npm ci to install the newly added dependencies locally and npm start to launch the app.
  • Open a second terminal to run the typescript compiler using tsc --noEmit --watch to see any type issue.
  • After installing the new dependencies and starting the app you should see that default styling of the bootstrap on all buttons and inputs
  • Navigate through the application making sure all functionality still works

@bbland1 bbland1 marked this pull request as ready for review September 25, 2024 23:15
Copy link

github-actions bot commented Sep 25, 2024

Visit the preview URL for this PR (updated for commit 22cc8fd):

https://tcl-77-smart-shopping-list--pr45-bb-bootstrap-integra-bdivb2e4.web.app

(expires Sat, 05 Oct 2024 09:57:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b77df24030dca7d8b6561cb24957d2273c5e9d72

@bbland1 bbland1 self-assigned this Sep 25, 2024
Copy link
Collaborator

@RossaMania RossaMania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great implementation of Bootstrap! You were able to install and import Bootstrap, and use some default Bootstrap components without making big styling decisions! Nice job! This should give us some inspiration

@eternalmaha
Copy link
Collaborator

eternalmaha commented Sep 27, 2024

Thanks for implementing this! The blue and more animated feel of the buttons in the list view is growing on me. Everything appears to be working as it should too and I dont see anything breaking at all!!!
This is probably unrealted, but the only odd thing I noticed is that for my absurdly large list, the list is cut off at when my window is minimized somewhat. Im not able to scroll down to the bottom of the list. The issue goes away and I can scroll normally at full window. This probably existed beforehand and am just now realizing this about the list since I don't see how bootstrap would change this unless its a default sizing thing built in, i'm not really sure honestly?) I'm assuming this will all be taken care of anyways when and if we make the app mobile responsive! :) Great job with all the integration!!!!! Thanks for doing this and getting us started!!! Screenshot 2024-09-27 at 4 15 50 PM

{"Add items"}
</button>
</section>
<section className="sticky-top bg-dark">
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right background color but needed to set it to something to see the scrolling and make sure ti stuck to the top correctly!

Copy link
Collaborator

@alex-andria alex-andria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Brianna and thanks for taking initiative on this! Already looking great and can't wait to see how you all style this with the SCSS PR Falak put up as well.

@bbland1 bbland1 merged commit fceec4b into main Sep 29, 2024
2 checks passed
@bbland1 bbland1 deleted the bb/bootstrap-integration branch September 29, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants