-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bb/bootstrap integration #45
Conversation
… doesn't utilize input="search"
Visit the preview URL for this PR (updated for commit 22cc8fd): https://tcl-77-smart-shopping-list--pr45-bb-bootstrap-integra-bdivb2e4.web.app (expires Sat, 05 Oct 2024 09:57:22 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b77df24030dca7d8b6561cb24957d2273c5e9d72 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great implementation of Bootstrap! You were able to install and import Bootstrap, and use some default Bootstrap components without making big styling decisions! Nice job! This should give us some inspiration
{"Add items"} | ||
</button> | ||
</section> | ||
<section className="sticky-top bg-dark"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the right background color but needed to set it to something to see the scrolling and make sure ti stuck to the top correctly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work Brianna and thanks for taking initiative on this! Already looking great and can't wait to see how you all style this with the SCSS PR Falak put up as well.
Description
We discussed using
bootstrap
andreact-bootstap
in the application this installs them and changes our buttons, inputs, navbar to utilize it. Makes sure the app still looks and functions the same with thebootstrap
default styling basically.Acceptance Criteria
Type of Changes
Updates
Before
After
Testing Steps / QA Criteria
To make sure the dependencies and code function as should:
git pull origin bb/bootstrap-integration
and check that branch out with git checkout `bb/bootstrap-integration``npm ci
to install the newly added dependencies locally andnpm start
to launch the app.tsc --noEmit --watch
to see any type issue.bootstrap
on all buttons and inputs