Refactor to typescript #50
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- install types and necessary dependencies; - add TypeScript configuration; - change extention of files to .tsx; - add User and Item types.
…rn in the input element
… List component; removed temporary console.log from Home component
…n in case userId or userEmail is undefined
deeheber
reviewed
Sep 19, 2024
src/api/firebase.ts
Outdated
Comment on lines
28
to
29
| userId: string | null | undefined, | ||
| userEmail: string | null | undefined, |
There was a problem hiding this comment.
I wonder if this might simplify a little bit
Suggested change
| userId: string | null | undefined, | |
| userEmail: string | null | undefined, | |
| userId?: string | null, | |
| userEmail?: string | null, |
deeheber
reviewed
Sep 19, 2024
tsconfig.json
Outdated
Comment on lines
1
to
13
| { | ||
| "compilerOptions": { | ||
| "target": "es6", | ||
| "module": "esnext", | ||
| "moduleResolution": "node", | ||
| "jsx": "react-jsx", | ||
| "strict": true, | ||
| "esModuleInterop": true, | ||
| "skipLibCheck": true, | ||
| "forceConsistentCasingInFileNames": true | ||
| }, | ||
| "include": ["src"] | ||
| } |
There was a problem hiding this comment.
The build works on my end now with the vite command.
I wonder if it was the file name change from vit2.config.js > vite.config.ts that did it.
I also see the built files in /build too which makes things nicer. 🙌🏻
…and firebase.ts; - add types to firebase functions; - add types to a new deleteItem function;
|
Visit the preview URL for this PR (updated for commit 0400b4c): https://tcl-75-smart-shopping-list--pr50-refactor-to-typescri-pom1hab6.web.app (expires Fri, 04 Oct 2024 14:54:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1f1fd53c369e1fa31e15c310aa075b4e8f4f8dde |
- ensure that values passed into the functions are not undefined; - update pros typing in order to support intellisense onhover; - add onhover description of deleteItem function.
…ull, replace null with /
…ns to support intellisense hovers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This code proposes refactoring our application to TypeScript. These changes will keep the app type safe, scalable and easy to read and to debug.
Some console logs are still in place as the work is still in progress.
Issue
closes #56
Type of Changes
enhancementUpdates
Added types.
Issues
Testing Steps / QA Criteria
npm startand navigated to localhost:3000,