-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #12: Delete Items from Shopping List #31
Conversation
…e JS confirm dialog and shows user a message accordingly.
Visit the preview URL for this PR (updated for commit c67fe33): https://tcl-74-smart-shopping-list--pr31-st-sd-12-jeqqigim.web.app (expires Thu, 26 Sep 2024 23:25:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 79d73546692f99aad8468c28e36db434e2c190ac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very Nice, Works great, and I like the dynamic aria label as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I tested it and it works well on my end 🌻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey team, looks good but it would be a good idea while testing to also test some of the other flows that happen on this page. So I marked an item as purchased, and also searched for items in the search bar and the success message remained, which was a little strange.
- I deleted an item, then marked another as purchased, but the deleted message remained. If you are creating a success message for one action, I would consider making sure the behavior is the same for the other.
Something you can consider is having the message time out after a few seconds, but just making sure the message reflects the most recent action is a good place to start.
…nge input for search item
Thank you @jtkabenni, for the suggestions. The code has been refactored to remove the message after 5 seconds and the message also gets removed when anything is typed on search items. Thank you. |
Description
This PR allows users to delete items from their shopping list.
Related Issue
Acceptance Criteria
ListItem
component renders a button that allows the user to delete an item from their list when clicked.deleteItem
function inapi/firebase.js
has been filled out, and deletes the item from the Firestore database.Type of Changes
Updates
Before
After
Testing Steps / QA Criteria
List
page.Delete
button for the item you would like to delete.OK
to confirm.