-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style the AddItem component #53
Conversation
Visit the preview URL for this PR (updated for commit 5c81afc): https://tcl-44-smart-shopping-list--pr53-rb-style-add-item-pa-aedjev8f.web.app (expires Thu, 02 Jun 2022 12:42:43 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Reda!
Excellent job @redapy 🚀 |
Cyan would be the perfect combination for the success message IMO |
I agree with Jimena, cyan would look good. I'd just check the colour contrast of the cyan on the white. If it fails, then try a higher number like cyan-600 until it passes the contrast. |
Great job with the changes @redapy! I love the way it looks with the messages now. This I found very instructive in relation to using aria-label or aria-labelledby https://tink.uk/the-difference-between-aria-label-and-aria-labelledby/. Also this https://www.w3.org/TR/WCAG20-TECHS/ARIA14.html |
Thanks for the great review. I used |
For an example of how to fill this template out, see this Pull Request.
Description
This PR style the "Add item" page, and remove the "filter text" from the
Search component
custom-forms
plugin.Related Issue
Closes #48
Closes #52
Type of Changes
Updates
Before
After
Testing Steps / QA Criteria
git pull origin rb-style-add-item-page
and check that branch out withgit checkout rb-style-add-item-page
npm install
to install the new dependecieTest searching the list