Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aliasing in Element questions #88

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

munichbughunter
Copy link
Contributor

@munichbughunter munichbughunter commented Aug 12, 2024

Issue number: resolves #86 & #87

Proposed changes

I checked all exported member and add they which were missed.
Updated the Element class to enable validating an element with ability aliasing.

Types of changes

What types of changes does your code introduce to Testla?
Put an x in the boxes that apply

  • Bugfix
  • New feature
  • Regression
  • Documentation Update

Checklist

  • Lint and (unit) tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added/updated necessary documentation
  • I have considered ability aliasing
  • I have considered logging

Copy link

github-actions bot commented Aug 12, 2024

Qodana for JS

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@munichbughunter munichbughunter marked this pull request as ready for review August 12, 2024 12:11
@munichbughunter munichbughunter linked an issue Aug 12, 2024 that may be closed by this pull request
@munichbughunter munichbughunter self-assigned this Aug 12, 2024
@munichbughunter munichbughunter added the bug Something isn't working label Aug 12, 2024
@munichbughunter munichbughunter merged commit ab0bf0f into main Aug 12, 2024
3 of 7 checks passed
@munichbughunter munichbughunter deleted the fix/ability-aliasing-in-questions branch August 12, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Element Question - Ability Aliasing not used 🐞 Module has no exported member 'Reload'
2 participants