Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop usage of react-dom/test-utils #1270

Closed
wants to merge 6 commits into from

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jan 30, 2024

BREAKING CHANGE
The legacyRoot option is no longer supported now that ReactDOM.render has been removed from React. There is no alternative.

To ensure compatibility with React Testing Library 15, make sure you're not using the legacyRoot option in any of your calls to render from React Testing Library.

React 18 is still supported but you will see deprecation warnings from react-dom/test-utils. Either suppress these warnings or switch to React 19.

Copy link

codesandbox-ci bot commented Jan 30, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 997c8c1:

Sandbox Source
React Configuration
react-testing-library-examples Configuration

@MatanBobi
Copy link
Member

Thanks Sebastian. Is there any documentation about this change? Are they just deprecating the module?

@cayter
Copy link

cayter commented Apr 1, 2024

Thanks Sebastian. Is there any documentation about this change? Are they just deprecating the module?

This is the related doc.

@MatanBobi
Copy link
Member

Thanks Sebastian. Is there any documentation about this change? Are they just deprecating the module?

This is the related doc.

Thanks.. This was created by @eps1lon himself :)

https://github.com/reactjs/react.dev/blob/main/src/content/warnings/react-dom-test-utils.md

@eps1lon
Copy link
Member Author

eps1lon commented Apr 8, 2024

Favoring #1294 which adds React 19 support in a SemVer MINOR.

@eps1lon eps1lon closed this in #1294 Apr 8, 2024
@eps1lon eps1lon deleted the feat/react-19 branch April 17, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants