Correct log files for Qconnect #440
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HolQue
reviewed
Feb 12, 2025
| @@ -38,9 +38,8 @@ for target_dir in "${value_array[@]}"; do | |||
| if [ $? -ne 0 ]; then | |||
| real_src_path=$(realpath $(dirname $source_log_file)) | |||
| echo -e "\e[31mError:\e[0m No files to copy files from $real_src_path" | |||
| echo "Please correct the directory to contain all log files." | |||
| exit 1 | |||
There was a problem hiding this comment.
The wording is a bit curious. Files are missing. This is interpreted as error. OK so far. But do we really need an additional hint that something needs to be corrected? I don't think so.
How about a shorter version:
Error: No log files found in '$real_src_path'.
This should be enough.
There was a problem hiding this comment.
Hi Holger,
I think we need to warn the user to pay attention to additional test log files.
Therefore, I will change "Error" to "Warning" with a shorter version, as you mentioned.
Please help me review it and let me know if you have any concerns.
Best regards,
Thong Hua
There was a problem hiding this comment.
Hi Thong,
fine to me.
Best regards
Holger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Thomas,
Cc Holger
I have updated the option on QConnect.
Please help me review it.
#438
Thank you and best regards,
Thong Hua